Port |Bug 746859 - Add a play icon to the click-to-play placeholder| to Modern

RESOLVED FIXED in seamonkey2.12

Status

SeaMonkey
Themes
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: InvisibleSmiley, Assigned: InvisibleSmiley)

Tracking

Trunk
seamonkey2.12

SeaMonkey Tracking Flags

(seamonkey2.11 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 622086 [details] [diff] [review]
patch [Checkin: Comments 2 and 5]

From the base bug:
"With the current plugin click-to-play placeholder you have to read the text to know it's click-to-play. Adding a play icon (triangle pointing right) would give a simpler at a glance understanding of what's going on. I suggest simply taking what is there now, making the Lego brick plugin icon significantly bigger, and sticking a play icon in the middle. It's just a minor change, but I think it could be a nice improvement."

As always I copied the image from Winstripe.
Attachment #622086 - Flags: review?(neil)

Comment 1

5 years ago
Bah, I have a tree which I can import a binary patch into but no plugins, or a tree with plugins that I can't import a binary patch into...

Updated

5 years ago
Attachment #622086 - Flags: review?(neil) → review+
(Assignee)

Comment 2

5 years ago
Comment on attachment 622086 [details] [diff] [review]
patch [Checkin: Comments 2 and 5]

http://hg.mozilla.org/comm-central/rev/d2208486e26c
Attachment #622086 - Attachment description: patch → patch [Checkin: Comment 2]
(Assignee)

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.12
(Assignee)

Comment 3

5 years ago
Comment on attachment 622086 [details] [diff] [review]
patch [Checkin: Comments 2 and 5]

[Approval Request Comment]
Regression caused by (bug #): bug 746859 (landed on m-a)
User impact if declined: Inconsistency between Classic and Modern
Testing completed (on m-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none
Attachment #622086 - Flags: approval-comm-aurora?

Comment 4

5 years ago
Comment on attachment 622086 [details] [diff] [review]
patch [Checkin: Comments 2 and 5]

a=me
Attachment #622086 - Flags: approval-comm-aurora? → approval-comm-aurora+
(Assignee)

Comment 5

5 years ago
Comment on attachment 622086 [details] [diff] [review]
patch [Checkin: Comments 2 and 5]

http://hg.mozilla.org/releases/comm-aurora/rev/f33caeec80fc
Attachment #622086 - Attachment description: patch [Checkin: Comment 2] → patch [Checkin: Comments 2 and 5]
(Assignee)

Updated

5 years ago
status-seamonkey2.11: --- → fixed
You need to log in before you can comment on or make changes to this bug.