753101 - Re-enable gc-zeal in the shell

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Terrence Cole [:terrence]]

It appears to have gotten accidentally disabled in Bug 742570.

Comment 1

[Terrence Cole [:terrence]]

Attachment: v0

This works for me locally.

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 622191 [details] [diff] [review]
v0

Review of attachment 622191 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

::: js/src/jsapi.cpp
@@ +6591,2 @@
>          zeal = atoi(env);
> +        frequency = !!p ? atoi(p + 1) : 100;

No need for the !!p; it can be just p. And instead of 100 please use JS_DEFAULT_ZEAL_FREQ.

::: js/src/shell/js.cpp
@@ +5008,5 @@
>          return 1;
>  
>      JS_SetGCParameter(rt, JSGC_MODE, JSGC_MODE_INCREMENTAL);
>      JS_SetGCParameterForThread(cx, JSGC_MAX_CODE_CACHE_BYTES, 16 * 1024 * 1024);
> +    JS_SetGCZeal(cx, 0, 0);

You need to put #ifdef JS_GC_ZEAL around this or else it won't compile.

Comment 3

[Terrence Cole [:terrence]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a254a5886fc6

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a254a5886fc6