Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Re-enable gc-zeal in the shell

RESOLVED FIXED in mozilla15

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: terrence, Assigned: terrence)

Tracking

Trunk
mozilla15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
It appears to have gotten accidentally disabled in Bug 742570.
(Assignee)

Updated

5 years ago
Assignee: general → terrence
(Assignee)

Comment 1

5 years ago
Created attachment 622191 [details] [diff] [review]
v0

This works for me locally.
Attachment #622191 - Flags: review?(wmccloskey)
Comment on attachment 622191 [details] [diff] [review]
v0

Review of attachment 622191 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

::: js/src/jsapi.cpp
@@ +6591,2 @@
>          zeal = atoi(env);
> +        frequency = !!p ? atoi(p + 1) : 100;

No need for the !!p; it can be just p. And instead of 100 please use JS_DEFAULT_ZEAL_FREQ.

::: js/src/shell/js.cpp
@@ +5008,5 @@
>          return 1;
>  
>      JS_SetGCParameter(rt, JSGC_MODE, JSGC_MODE_INCREMENTAL);
>      JS_SetGCParameterForThread(cx, JSGC_MAX_CODE_CACHE_BYTES, 16 * 1024 * 1024);
> +    JS_SetGCZeal(cx, 0, 0);

You need to put #ifdef JS_GC_ZEAL around this or else it won't compile.
Attachment #622191 - Flags: review?(wmccloskey) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/a254a5886fc6

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/a254a5886fc6
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.