Last Comment Bug 753105 - Change Websocket "internal error" code to 1011.
: Change Websocket "internal error" code to 1011.
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Networking: WebSockets (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla14
Assigned To: Jason Duell [:jduell] (needinfo? me)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-08 14:03 PDT by Jason Duell [:jduell] (needinfo? me)
Modified: 2012-05-30 07:19 PDT (History)
4 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
v1. Change WS internal error close code to 2011 (2.39 KB, patch)
2012-05-08 14:03 PDT, Jason Duell [:jduell] (needinfo? me)
mcmanus: review+
lukasblakk+bugs: approval‑mozilla‑aurora+
lukasblakk+bugs: approval‑mozilla‑beta-
Details | Diff | Review

Description Jason Duell [:jduell] (needinfo? me) 2012-05-08 14:03:04 PDT
Created attachment 622137 [details] [diff] [review]
v1.  Change WS internal error close code to 2011

Not clear if this is going to make it into RFC, but seems to have consensus:

  http://www.ietf.org/mail-archive/web/hybi/current/msg09372.html

We landed the current internal_error = 1001 logic in FF 13: I think we should try to get this on aurora/beta so we don't have to change our story (and docs) about what error code we return when we hit internal errors.

I also added 2015, which is in the spec, but we're not using currently (Patrick, do you know if we should be using it for TLS cert errors?  I assume we should open a bug for that).
Comment 1 Takashi Toyoshima 2012-05-08 18:02:03 PDT
Subject and description looks having wrong codes.
2011 and 2015 must be 1011 and 1015.
The patch contains right codes.
Comment 2 Jason Duell [:jduell] (needinfo? me) 2012-05-08 18:07:17 PDT
Right you are--I must have confused the code with what year it is (except that was last year :)

I'll take getting bugzilla text wrong but having the code right over the opposite, any day.

thanks Takashi
Comment 3 Jason Duell [:jduell] (needinfo? me) 2012-05-16 16:59:25 PDT
This change is now official:

  http://www.rfc-editor.org/errata_search.php?rfc=6455&eid=3227
Comment 4 Patrick McManus [:mcmanus] 2012-05-17 07:22:08 PDT
Comment on attachment 622137 [details] [diff] [review]
v1.  Change WS internal error close code to 2011

please also file the bug for generating 1015 in JS when TLS fails.
Comment 5 Jason Duell [:jduell] (needinfo? me) 2012-05-17 11:06:48 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/48bd6f4c119a

Filed bug 756165 for the TLS code (1015) issue.
Comment 6 Jason Duell [:jduell] (needinfo? me) 2012-05-17 11:10:22 PDT
Comment on attachment 622137 [details] [diff] [review]
v1.  Change WS internal error close code to 2011

~0% risk change--just update the close code we use for "internal error" to meet the websocket spec.  Would be nice to have ASAP, and I can't see any risk at all (no addons should be using nsIWebSocketChannel--it's a low-level IDL).

User impact if declined: websocket servers will get wrong code when we close connection with "internal error", so they won't know that's what happened.

String or UUID changes made by this patch: no
Comment 7 Ryan VanderMeulen [:RyanVM] 2012-05-17 20:38:16 PDT
(In reply to Jason Duell (:jduell) from comment #5)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/48bd6f4c119a
> 
> Filed bug 756165 for the TLS code (1015) issue.

https://hg.mozilla.org/mozilla-central/rev/48bd6f4c119a
Comment 8 Lukas Blakk [:lsblakk] use ?needinfo 2012-05-21 15:19:02 PDT
Comment on attachment 622137 [details] [diff] [review]
v1.  Change WS internal error close code to 2011

[Triage Comment]
we're only taking critical fixes for beta at this point so only approving for aurora.
Comment 9 Jason Duell [:jduell] (needinfo? me) 2012-05-21 15:49:48 PDT
https://hg.mozilla.org/releases/mozilla-aurora/rev/0bdcb1fe8c2e

Note You need to log in before you can comment on or make changes to this bug.