Last Comment Bug 753118 - Uninitialised value use in nsWindow::Destroy
: Uninitialised value use in nsWindow::Destroy
Status: RESOLVED FIXED
: valgrind
Product: Core
Classification: Components
Component: Widget: Gtk (show other bugs)
: Trunk
: x86_64 Linux
: -- normal (vote)
: mozilla15
Assigned To: Julian Seward [:jseward]
:
Mentors:
Depends on:
Blocks: 497498
  Show dependency treegraph
 
Reported: 2012-05-08 14:42 PDT by Julian Seward [:jseward]
Modified: 2012-05-10 08:04 PDT (History)
2 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
A possible fix (911 bytes, patch)
2012-05-08 14:44 PDT, Julian Seward [:jseward]
karlt: review+
Details | Diff | Splinter Review

Description Julian Seward [:jseward] 2012-05-08 14:42:00 PDT
m-c, x86_64-linux, seems to happen every startup (and possibly every
shutdown too)

Use of uninitialised value of size 8
   at 0x6DB4291: nsWindow::Destroy() (widget/gtk2/nsWindow.cpp:682)
   by 0x680C3B6: nsView::DestroyWidget() (view/src/nsView.cpp:296)
   by 0x680CCA7: nsView::~nsView() (view/src/nsView.cpp:267)
   by 0x680C452: nsIView::Destroy() (view/src/nsView.cpp:341)
   by 0x6810366: nsViewManager::~nsViewManager() (view/src/nsViewManager.cpp:116)
   by 0x680E0BA: nsViewManager::Release() (view/src/nsViewManager.cpp:146)
   by 0x6F3EFCC: nsCOMPtr_base::assign_with_AddRef(nsISupports*) (xpcom/build/../glue/nsCOMPtr.h:469)
   by 0x6432BF5: DocumentViewerImpl::Destroy() (ff-opt/layout/base/../../dist/include/nsCOMPtr.h:651)
   by 0x6433A11: DocumentViewerImpl::Show() (layout/base/nsDocumentViewer.cpp:1967)
   by 0x6446B2A: nsPresContext::EnsureVisible() (layout/base/nsPresContext.cpp:1845)
   by 0x64525F8: PresShell::UnsuppressAndInvalidate() (layout/base/nsPresShell.cpp:3578)
   by 0x645C105: PresShell::ProcessReflowCommands(bool) (layout/base/nsPresShell.cpp:7674)

 Uninitialised value was created by a heap allocation
   at 0x4029B9A: malloc (/home/sewardj/VgTRUNK/trunk/coregrind/m_replacemalloc/vg_replace_malloc.c:263)
   by 0x403D318: moz_xmalloc (memory/mozalloc/mozalloc.cpp:87)
   by 0x6DBAED4: nsDragServiceConstructor(nsISupports*, nsID const&, void**) (ff-opt/widget/gtk2/../../dist/include/mozilla/mozalloc.h:229)
   by 0x6F45E4E: mozilla::GenericFactory::CreateInstance(nsISupports*, nsID const&, void**) (ff-opt/xpcom/build/GenericFactory.cpp:48)
   by 0x6F71FD7: nsComponentManagerImpl::CreateInstanceByContractID(char const*, nsISupports*, nsID const&, void**) (xpcom/components/nsComponentManager.cpp:1064)
   by 0x6F74C2D: nsComponentManagerImpl::GetServiceByContractID(char const*, nsID const&, void**) (xpcom/components/nsComponentManager.cpp:1466)
   by 0x6F3FCD0: CallGetService(char const*, nsID const&, void**) (ff-opt/xpcom/build/nsComponentManagerUtils.cpp:94)
   by 0x6F3FD3B: nsGetServiceByContractID::operator()(nsID const&, void**) const (ff-opt/xpcom/build/nsComponentManagerUtils.cpp:278)
   by 0x6F3F15B: nsCOMPtr_base::assign_from_gs_contractid(nsGetServiceByContractID, nsID const&) (ff-opt/xpcom/build/nsCOMPtr.cpp:132)
   by 0x6450E45: PresShell::Init(nsIDocument*, nsPresContext*, nsIViewManager*, nsStyleSet*, nsCompatibility) (ff-opt/layout/base/../../dist/include/nsCOMPtr.h:701)
   by 0x6620B15: nsDocument::doCreateShell(nsPresContext*, nsIViewManager*, nsStyleSet*, nsCompatibility, nsIPresShell**) (content/base/src/nsDocument.cpp:3226)
   by 0x678B766: nsHTMLDocument::CreateShell(nsPresContext*, nsIViewManager*, nsStyleSet*, nsIPresShell**) (content/html/document/src/nsHTMLDocument.cpp:346)
Comment 1 Julian Seward [:jseward] 2012-05-08 14:44:44 PDT
Created attachment 622151 [details] [diff] [review]
A possible fix
Comment 2 Ryan VanderMeulen [:RyanVM] 2012-05-09 18:02:18 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/6d1ff855f85c
Comment 3 Ed Morley [:emorley] 2012-05-10 08:04:44 PDT
https://hg.mozilla.org/mozilla-central/rev/6d1ff855f85c

Note You need to log in before you can comment on or make changes to this bug.