Do win32 PGO builds on win64 machines

RESOLVED FIXED

Status

Release Engineering
General
P2
major
RESOLVED FIXED
6 years ago
2 months ago

People

(Reporter: catlee, Assigned: catlee)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(6 attachments, 2 obsolete attachments)

(Assignee)

Description

6 years ago
As a first step to switching wholesale to win64 machines for our builds, we can switch just our PGO and nightly builds over to win64 machines.
(Assignee)

Updated

6 years ago
Assignee: nobody → catlee
(Assignee)

Comment 1

6 years ago
Created attachment 622265 [details] [diff] [review]
Add support for 'pgo_slaves'

If 'pgo_slaves' is found in the platform config it will be used instead of 'slaves' for pgo builds.
Attachment #622265 - Flags: review?(rail)
(Assignee)

Comment 2

6 years ago
Created attachment 622267 [details] [diff] [review]
Set up build-system to do win32 pgo builds on win64 slaves
Attachment #622267 - Flags: review?(ted.mielczarek)
Attachment #622267 - Flags: review?(rail)
Comment on attachment 622267 [details] [diff] [review]
Set up build-system to do win32 pgo builds on win64 slaves

Review of attachment 622267 [details] [diff] [review]:
-----------------------------------------------------------------

Go for it!
Attachment #622267 - Flags: review?(ted.mielczarek) → review+
Attachment #622265 - Flags: review?(rail) → review+
Attachment #622267 - Flags: review?(rail) → review+
(Assignee)

Comment 4

6 years ago
Created attachment 622991 [details] [diff] [review]
Set up build-system to do win32 pgo builds on win64 slaves

Turns out that the old patch didn't work because we need to run with the win64 environment. I've switched from 'pgo_slaves' to 'pgo_platform' instead so that generateBranchObjects can grab the appropriate environment.

The only problem with this now is that the win32 PGO builds will have   MOZ_SYMBOLS_EXTRA_BUILDID=win64-${branch}
Attachment #622267 - Attachment is obsolete: true
Attachment #622991 - Flags: review?(rail)
(Assignee)

Comment 5

6 years ago
Created attachment 622992 [details] [diff] [review]
Use pgo_platform instead of pgo_slaves
Attachment #622265 - Attachment is obsolete: true
Attachment #622992 - Flags: review?(rail)
(Assignee)

Comment 6

6 years ago
Created attachment 622994 [details] [diff] [review]
mozconfig changes

we also need MOZ_TOOLS and PATH adjusted to find /c/Tools/sdks/v7.0/bin
Attachment #622994 - Flags: review?(ted.mielczarek)
Attachment #622994 - Flags: review?(ted.mielczarek) → review+
Attachment #622992 - Flags: review?(rail) → review+
Attachment #622991 - Flags: review?(rail) → review+
(Assignee)

Updated

6 years ago
Attachment #622991 - Flags: checked-in+
(Assignee)

Updated

6 years ago
Attachment #622992 - Flags: checked-in+

Comment 7

6 years ago
A change from this bug landed on the default branches of either buildbot-configs or buildbotcustom.
Such change has been merged as of ~8:30 AM PDT into the production branches and the buildbot masters have been reconfigured.
This if FYI and a note has been added to the maintenance page:
https://wiki.mozilla.org/ReleaseEngineering:Maintenance#Reconfigs_.2F_Deployments
(Assignee)

Updated

6 years ago
Attachment #622994 - Flags: checked-in+
I finally have some QA results, sorry for the delay. Overall the builds are fine. We did run into a couple of issues which seem to be unique to this build when compared to the May 4th Nightly.

TAB key not working
-------------------
STR:
1. Open Firefox.
2. Press the Tab key to navigate through the opened website.

EXPECTED: 
When the Tab key is pressed, the focus moves to the next element on the web page.

RESULTS: 
Nothing happens when the Tab key is pressed.

Flash not working after re-enable
---------------------------------
STR:
1. Launch Firefox. Make sure the Flash Player plugin is installed.
2. Open the Addons Manager and Disable the Flash Player plugin.
3. Enable the Flash Player plugin.
4. Open a web page using Flash (http://www.youtube.com , http://www.addictinggames.com/  etc).

EXPECTED:
The Flash content is rendered without any issues.

RESULTS: 
The Flash content is not rendered at all.

Shockwave plug-in crash on miniclip.com
---------------------------------------
STR:
1. Launch Firefox. Make sure the Shockwave Flash plugin is installed.
2. Open a web page using Shockwave Flash (http://www.miniclip.com/games/white-water-rafting/ro/  etc).

EXPECTED: 
The Shockwave Flash content is rendered without any issues.

RESULTS:
When opening http://www.miniclip.com/games/white-water-rafting/ro/, a dialog that asks the user whether he wants to run a .exe is opened. If the user clicks "Cancel", Shockwave and the browser work fine. If the user clicks "Run", the browser hangs for about 10 seconds, after which the plugin crashes and the browser starts working fine.

Clicking link from external application displays profile manager
----------------------------------------------------------------
STR:
1. Launch Firefox.
2. Set Firefox your system's default browser.
3. Open another application that contains a hyperlink (e.g. an email opened in an email client, a document opened in a text editor etc).
4. Click the hyperlink.

EXPECTED: 
The link is opened in the win32-on-win64 Firefox, in a new tab.

RESULTS: 
When clicking on a hyperlink from another app (e.g. Thunderbird), the Profile Manager is opened although the win32-on-win64 try build is already opened. The user is only allowed to select a different profile and another Firefox is opened (Beta).
(In reply to Chris AtLee [:catlee] from comment #9)
> Thanks Anthony. Does this build also exhibit these problems?
> 
> http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/build-system-
> win32/1337025672/firefox-15.0a1.en-US.win32.zip

1. TAB key not working -> NOT reproducible
2. Flash not working after re-enable -> NOT reproducible
3. Shockwave plug-in crash on miniclip.com -> NOT reproducible
4. Clicking link from external application -> NOT reproducible
https://hg.mozilla.org/mozilla-central/rev/a0cca6997af4

Not sure whether this can be closed yet, so leaving open for now. For future patches, you can put [leave open] in the whiteboard to ensure the bug doesn't get closed as part of the merge.
(Assignee)

Comment 12

6 years ago
Created attachment 624363 [details] [diff] [review]
enable win64 32-bit pgo builds on m-c, fx-team, ionmonkey and services-central

turn on pgo builds on win64 wherever we have pgo_strategy set to something. this is for m-c, fx-team, ionmonkey and services-central at the moment.
Attachment #624363 - Flags: review?(bhearsum)
Attachment #624363 - Flags: review?(bhearsum) → review+
(Assignee)

Comment 13

6 years ago
Comment on attachment 624363 [details] [diff] [review]
enable win64 32-bit pgo builds on m-c, fx-team, ionmonkey and services-central

ionmonkey isn't actually affected here, it's mozilla-inbound.
Attachment #624363 - Flags: checked-in+

Comment 14

6 years ago
in production 2012-05-17 0750 PDT
(Assignee)

Comment 15

6 years ago
Created attachment 625087 [details] [diff] [review]
run periodic pgo on win64 too
Attachment #625087 - Flags: review?(bhearsum)
Attachment #625087 - Flags: review?(bhearsum) → review+
(Assignee)

Updated

6 years ago
Attachment #625087 - Flags: checked-in+
(Assignee)

Comment 16

6 years ago
Created attachment 625133 [details] [diff] [review]
fix environment for nightly pgo builds
Attachment #625133 - Flags: review?(bhearsum)
Attachment #625133 - Flags: review?(bhearsum) → review+
(Assignee)

Updated

6 years ago
Attachment #625133 - Flags: checked-in+
Depends on: 756878
(Assignee)

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
Component: General Automation → General
Product: Release Engineering → Release Engineering
You need to log in before you can comment on or make changes to this bug.