753178 - Remove mozilla-1.9.2 from buildbot-configs

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: removes 1.9.2 from buildbot-configs (tested)

3.6 is officially over, time to remove those custom configs from buildbot-configs.

The attached patch passed ./setup.py -t against all 56 masters' tests.  My only uncertainty in pulling things out was changing:

BRANCHES['addontester']['addon_tests'] = (1, False, TALOS_ADDON_OPTS, OLD_BRANCH_ADDON_TESTER_PLATFORMS)

to:

BRANCHES['addontester']['addon_tests'] = (1, False, TALOS_ADDON_OPTS, [])

now that we don't need the OLD_BRANCH anymore.

Comment 1

[[e-mail] (:bhearsum)]

We shouldn't do this until we know we aren't going to do any more 3.6.28 -> x MUs, because that automation requires the 1.9.2 branch to exist in config.py. We seem to be mostly doing 3.6.x -> x updates now though, which are done outside of buildbot, so maybe we're ok?

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Attachment 619150 [details] [diff] already removed the 1.9.2 release builders, and AIUI we're not going to offer 3.6.x users 13.0, so I think we're OK with the manual generation we've been doing.

Comment 3

[Chris Cooper [:coop] (he/him)]

Comment on attachment 622194 [details] [diff] [review]
removes 1.9.2 from buildbot-configs (tested)

Review of attachment 622194 [details] [diff] [review]:
-----------------------------------------------------------------

Patch is fine and passes preproduction sanity.

I think there are still a few files that have references to 1.9.2 though:

mozilla/master_common.py
mozilla/preproduction_config.py
mozilla/release-firefox-mozilla-1.9.2.py
mozilla/staging_release-firefox-mozilla-1.9.2.py
mozilla-tests/config.py
mozilla-tests/master_common.py
mozilla-tests/production_addon_config.py
mozilla-tests/production_config.py
setup-master.py

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: more broad removal of 1.9.2 from buildbot-configs

Now with extra 1.9.2 erasure - got the other files you mentioned, ran test-masters again successfully.

Comment 5

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 625672 [details] [diff] [review]
more broad removal of 1.9.2 from buildbot-configs

landed on default: http://hg.mozilla.org/build/buildbot-configs/rev/076ad0a94f16

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

ended up landing in 2 parts, cause I forgot `hg addremove` for the release configs: http://hg.mozilla.org/build/buildbot-configs/rev/0fc7f1f27d49

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [svn] Drop cron jobs for 1.9.2

This will squelch the cron mail we're getting now that 1.9.2 directories have been removed.

Comment 8

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [svn] Drop cron jobs for 1.9.2 (really)

Comment 9

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 633929 [details] [diff] [review]
[svn] Drop cron jobs for 1.9.2 (really)

Sending        files/cron/ffxbld
Sending        files/cron/tbirdbld
Transmitting file data ..
Committed revision 40994.

Comment 10

[Nick Thomas [:nthomas] (UTC+12)]

I cleaned up the remaining 1.9.2 dirs
 firefox/tinderbox-builds/*1.9.2*
 thunderbird/nightly/latest-comm-1.9.2{,-l10n}
The ones in firefox/nightly were done a few days ago.