753226 - release-sanity.py should check email address sanity & other items

Status: RESOLVED WONTFIX

(Release Engineering :: Release Automation, defect, P3)

Description

[hwine]

found during 13.0b3 release (bug 744592) - with the --dryrun option, the non-optional arg "host:port" for the pb on the build master is not validated.

My particular error was replacing the colon with a space, changing the number of arguments, and causing an exception when run without --dryrun option.

It would be good to validate the # arguments supplied to the command as part of --dryrun. Bonus points to ensuring a tcp connection can be made.

Comment 1

[[e-mail] (:bhearsum)]

Wanted, not highly important because entering the wrong host:port is unlikely to lead to bad things.

Comment 2

[hwine]

Attachment: tweak to check for email address sanity for staging runs

tacking on a change to check for email setup, as we've had a few issues with that of late. See bug 755989 for the fix for the latest incident, but this will catch others.

Manually tested against various config file combinations.

Comment 3

[hwine]

piggy backing some other changes on here.

Comment 4

[Aki Sasaki (not active)]

Comment on attachment 624654 [details] [diff] [review]
tweak to check for email address sanity for staging runs

I like this.

Will the |import platform| and the usage of |platform| as a variable name cause any confusion?
http://hg.mozilla.org/build/tools/file/acbaea8e273b/buildbot-helpers/release_sanity.py#l123

>+    if not is_real_release_box:
>+        # we don't want more than user (or user + release@) in all
>+        # emails, and 'staging' had better be part of the message prefix

This might not be quite accurate:

* We generally don't want people to send their staging email to release@.
* We also have [preprod-release], which goes to release@.

If you want to spend the time to account for it, I think it would go:

* preproduction emails aren't real releases, and should go to release@
* staging emails aren't real releases, and should *not* go to either release-drivers@ or release@.

This is an improvement overall, so I'm not going to block on that.  However, this looks like it might break preproduction.

Thanks for the patch!  r-'ing because of preproduction emails, but it's close.

Comment 5

[Rail Aliiev [:rail]]

I don't think we are going to work on this. Let's kill it.