Closed Bug 753272 Opened 8 years ago Closed 8 years ago

bustage fix: make package fails due to Bug 749018

Categories

(SeaMonkey :: Build Config, defect, P1, blocker)

defect

Tracking

(Not tracked)

VERIFIED FIXED
seamonkey2.12

People

(Reporter: philip.chee, Assigned: philip.chee)

References

Details

Attachments

(2 files)

Bug 749018 - Make OOP <iframe mozbrowser> pass current browser frame tests
Changed some component names.
I'll take the first review from either Callek or Serge.
Attachment #622339 - Flags: review?(sgautherie.bz)
Attachment #622339 - Flags: review?(bugspam.Callek)
Comment on attachment 622339 [details] [diff] [review]
Build Bustage Fix.

Defer to serge....
Attachment #622339 - Flags: review?(bugspam.Callek)
Severity: normal → blocker
Depends on: 749018
Flags: in-testsuite-
Priority: -- → P1
Target Milestone: --- → seamonkey2.12
Comment on attachment 622339 [details] [diff] [review]
Build Bustage Fix.

Add BrowserElementAPI.js to removed-files.in too, fwiw.
Attachment #622339 - Flags: review?(sgautherie.bz) → review+
Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/6909d61b41b8

> Add BrowserElementAPI.js to removed-files.in too, fwiw.
Can you check that I've put the removed file in the right place?
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
(In reply to Philip Chee from comment #4)
> > Add BrowserElementAPI.js to removed-files.in too, fwiw.
> Can you check that I've put the removed file in the right place?

BrowserElementParent.js was correctly added ;-)
BrowserElementAPI.js should be moved out of the OMNIJAR block now.
(I'm sorry I wasn't explicit enough.)
Ftr, a Try log before the fix:

https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=fe384bbc57c1
https://tbpl.mozilla.org/php/getParsedLog.php?id=11594264&tree=Thunderbird-Try&full=1
TB WINNT 5.2 try-comm-central build on 2012-05-08 19:51:38 PDT for push fe384bbc57c1
{
Error: package error or possible missing or unnecessary file: bin/components/BrowserElementAPI.js (package-manifest, 232).
Error: package error or possible missing or unnecessary file: bin/components/BrowserElementAPI.manifest (package-manifest, 233).
}
>>> Add BrowserElementAPI.js to removed-files.in too, fwiw.
>> Can you check that I've put the removed file in the right place?
> 
> BrowserElementParent.js was correctly added ;-)
> BrowserElementAPI.js should be moved out of the OMNIJAR block now.
> (I'm sorry I wasn't explicit enough.)
Followup fix attached for your review.
Attachment #622499 - Flags: review?(sgautherie.bz)
Attachment #622499 - Flags: review?(sgautherie.bz) → review+
Pushed followup fix to comm-central
> http://hg.mozilla.org/comm-central/rev/7f0b2a4c89c0
V.Fixed, as builds are succeeding again.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.