753272 - bustage fix: make package fails due to Bug 749018

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect, P1)

Description

[Philip Chee]

Bug 749018 - Make OOP <iframe mozbrowser> pass current browser frame tests
Changed some component names.

Comment 1

[Philip Chee]

Attachment: Build Bustage Fix.

I'll take the first review from either Callek or Serge.

Comment 2

[Justin Wood (:Callek)]

Comment on attachment 622339 [details] [diff] [review]
Build Bustage Fix.

Defer to serge....

Comment 3

[Serge Gautherie (:sgautherie)]

Comment on attachment 622339 [details] [diff] [review]
Build Bustage Fix.

Add BrowserElementAPI.js to removed-files.in too, fwiw.

Comment 4

[Philip Chee]

Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/6909d61b41b8

> Add BrowserElementAPI.js to removed-files.in too, fwiw.
Can you check that I've put the removed file in the right place?

Comment 5

[Serge Gautherie (:sgautherie)]

(In reply to Philip Chee from comment #4)
> > Add BrowserElementAPI.js to removed-files.in too, fwiw.
> Can you check that I've put the removed file in the right place?

BrowserElementParent.js was correctly added ;-)
BrowserElementAPI.js should be moved out of the OMNIJAR block now.
(I'm sorry I wasn't explicit enough.)

Comment 6

[Serge Gautherie (:sgautherie)]

Ftr, a Try log before the fix:

https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=fe384bbc57c1
https://tbpl.mozilla.org/php/getParsedLog.php?id=11594264&tree=Thunderbird-Try&full=1
TB WINNT 5.2 try-comm-central build on 2012-05-08 19:51:38 PDT for push fe384bbc57c1
{
Error: package error or possible missing or unnecessary file: bin/components/BrowserElementAPI.js (package-manifest, 232).
Error: package error or possible missing or unnecessary file: bin/components/BrowserElementAPI.manifest (package-manifest, 233).
}

Comment 7

[Philip Chee]

Attachment: Patch v2.0 Followup fix.

>>> Add BrowserElementAPI.js to removed-files.in too, fwiw.
>> Can you check that I've put the removed file in the right place?
> 
> BrowserElementParent.js was correctly added ;-)
> BrowserElementAPI.js should be moved out of the OMNIJAR block now.
> (I'm sorry I wasn't explicit enough.)
Followup fix attached for your review.

Comment 8

[Philip Chee]

Pushed followup fix to comm-central
> http://hg.mozilla.org/comm-central/rev/7f0b2a4c89c0

Comment 9

[Serge Gautherie (:sgautherie)]

V.Fixed, as builds are succeeding again.