Closed
Bug 75339
Opened 25 years ago
Closed 25 years ago
[BeOS] Fix color issues with libpr0n
Categories
(Core :: Graphics: ImageLib, defect)
Tracking
()
VERIFIED
FIXED
mozilla0.9
People
(Reporter: wade, Assigned: wade)
Details
(Whiteboard: [imagelib] have patch, need r/sr/a)
Attachments
(2 files)
|
3.18 KB,
patch
|
Details | Diff | Splinter Review | |
|
703 bytes,
patch
|
Details | Diff | Splinter Review |
This simple patch fixes a BGR<->RGB color issue under BeOS.
Add XP_BEOS to the XP_PC #ifdefs
|
Assignee | |
Comment 1•25 years ago
|
||
|
|
||
Comment 2•25 years ago
|
||
Hi, the patch is working well for the color issue.
Thanks, Wade!
|
|
Assignee | |
Updated•25 years ago
|
Target Milestone: --- → mozilla0.9
|
||
Comment 4•25 years ago
|
||
Are you still shooting for 0.9 on this? If so please email drivers@mozilla.org
with a status on you progress. If not please retarget against a later Milestone.
Thanks.
|
||
Comment 5•25 years ago
|
||
fixed.
|
|
Assignee | |
Comment 7•25 years ago
|
||
Reopening.
Pav's modified patch causes a crash in JPEGDecoder. png and gif appear to be okay.
segment violation occurred
memset_default:
memset_default:
+002d ec091365: * 0f8b movl (%edi), %ecx
mozilla-bin:sc
frame retaddr
fd0014ac eca0b573 nsJPEGDecoder::WriteFrom(nsIInputStream *, unsigned int,
unsigned int *) + 000004f7
fd0014f0 ed669670 imgRequest::OnDataAvailable(nsIRequest *, nsISupports *,
nsIInputStream *, unsigned int, unsigned int) + 000002a4
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 8•25 years ago
|
||
|
|
Assignee | |
Comment 9•25 years ago
|
||
The newly attached patch appears to fix the JPEG crash issues.
|
||
Updated•25 years ago
|
Whiteboard: [imagelib] → [imagelib] have patch, need r/sr/a
|
|
||
Comment 10•25 years ago
|
||
Need some fast review and approval to get this into 0.9.
/be
|
|
||
Comment 11•25 years ago
|
||
argh. r=pavlov
|
|
||
Comment 12•25 years ago
|
||
a= asa@mozilla.org for checkin to 0.9
|
|
||
Comment 13•25 years ago
|
||
Who is the QA for BeOS? Please reassign qa contact accordingly. Thank you.
|
|
||
Comment 14•25 years ago
|
||
Who is gonna check in? I'll sr=brendan@mozilla.org, it's a trivial fix.
/be
|
||
Comment 16•25 years ago
|
||
fix checked in
Status: NEW → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•