Remove device space pageSize from setPageSize()

RESOLVED FIXED in Firefox 16

Status

()

Firefox for Android
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jrmuizel, Assigned: kats)

Tracking

unspecified
Firefox 16
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(firefox16 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
We currently convert the device space page size to be scaled by our current zoom. We should be able to just do this conversion from the cssPageSize. This will remove three of the parameters to setPageSize(). We should also make sure that we change the condition for calling setPageSize() to be a change in the CSS pixel size.
(Reporter)

Updated

5 years ago
Assignee: nobody → bugmail.mozilla
Created attachment 632738 [details] [diff] [review]
Patch
Attachment #632738 - Flags: review?(jmuizelaar)
(Reporter)

Comment 2

5 years ago
Comment on attachment 632738 [details] [diff] [review]
Patch

This looks lovely to me.
Attachment #632738 - Flags: review?(jmuizelaar) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/636b108f9729
status-firefox16: --- → fixed
Target Milestone: --- → Firefox 16

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/636b108f9729
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.