Closed Bug 753479 Opened 9 years ago Closed 9 years ago

Make HashTable's rekeyFront take a separate Lookup

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla15

People

(Reporter: terrence, Assigned: terrence)

References

Details

Attachments

(1 file)

Attached patch v0Splinter Review
I was hoping to do without this for GenerationalGC, but I may have been a bit optimistic.  There are two things pushing me towards doing this now, rather than later.  1) I'm touching all of the call sites that would need this right now to update to an indirect IsAboutToBeFinalized.  There's little point dumping this onto whoever ends up doing MovingGC, since I've already done most of the work.   2) I think we may need this for proto objects in the initial shape table, even for GenerationalGC.
Attachment #622460 - Flags: review?(luke)
Comment on attachment 622460 [details] [diff] [review]
v0

I just noticed: could you replace 'table.match' with either 'match' or (if template errors...) HashTable::match?
Attachment #622460 - Flags: review?(luke) → review+
https://hg.mozilla.org/mozilla-central/rev/157bf3e3ccde
Assignee: general → terrence
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.