Make HashTable's rekeyFront take a separate Lookup

RESOLVED FIXED in mozilla15

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: terrence, Assigned: terrence)

Tracking

Trunk
mozilla15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 622460 [details] [diff] [review]
v0

I was hoping to do without this for GenerationalGC, but I may have been a bit optimistic.  There are two things pushing me towards doing this now, rather than later.  1) I'm touching all of the call sites that would need this right now to update to an indirect IsAboutToBeFinalized.  There's little point dumping this onto whoever ends up doing MovingGC, since I've already done most of the work.   2) I think we may need this for proto objects in the initial shape table, even for GenerationalGC.
Attachment #622460 - Flags: review?(luke)

Comment 1

5 years ago
Comment on attachment 622460 [details] [diff] [review]
v0

I just noticed: could you replace 'table.match' with either 'match' or (if template errors...) HashTable::match?
Attachment #622460 - Flags: review?(luke) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/157bf3e3ccde

Comment 3

5 years ago
https://hg.mozilla.org/mozilla-central/rev/157bf3e3ccde
Assignee: general → terrence
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.