753526 - talos tries to kill processes that do not exist

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Jeff Hammel]

From https://bug729205.bugzilla.mozilla.org/attachment.cgi?id=622408 :

18:25:26     INFO -  NOISE:
__startBeforeLaunchTimestamp1336526720112__endBeforeLaunchTimestamp
18:25:26     INFO -  NOISE:
__startAfterTerminationTimestamp1336526721336__endAfterTerminationTimestamp
18:25:26    ERROR -  Traceback (most recent call last):
18:25:26     INFO -    File "/src/jhammel/build/venv/bin/talos", line
9, in <module>
18:25:26     INFO -      load_entry_point('talos==0.0',
'console_scripts', 'talos')()
18:25:26     INFO -    File
"/src/jhammel/build/venv/lib/python2.6/site-packages/talos/run_tests.py",
line 636, in main
18:25:26     INFO -      test_file(arg, options, parser.parsed)
18:25:26     INFO -    File
"/src/jhammel/build/venv/lib/python2.6/site-packages/talos/run_tests.py",
line 573, in test_file
18:25:26     INFO -      browser_dump, counter_dump, print_format =
mytest.runTest(browser_config, test)
18:25:26     INFO -    File
"/src/jhammel/build/venv/lib/python2.6/site-packages/talos/ttest.py",
line 343, in runTest
18:25:26     INFO -      process.kill()
18:25:26     INFO -    File
"/opt/local/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/subprocess.py",
line 1274, in kill
18:25:26     INFO -      self.send_signal(signal.SIGKILL)
18:25:26     INFO -    File
"/opt/local/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/subprocess.py",
line 1264, in send_signal
18:25:26     INFO -      os.kill(self.pid, sig)
18:25:26     INFO -  OSError: [Errno 3] No such process
18:25:26    ERROR - Return code: 1

The code is here
http://hg.mozilla.org/build/talos/file/e1022c38a8ed/talos/ttest.py#l343

My hypothesis is that the process is already gone before the os.kill
call get hit.  If this is the case, then it is fine to except: on
OSError (Errno 3) and just get on with our lives.  Should be an easy
fix, but there is an off chance that something more is going on here.

Comment 1

[Jeff Hammel]

FWIW, I don't encounter this on linux.  I can kill processes that don't exist just fine.

Comment 2

[Jeff Hammel]

this *should* be fixed with bug 704654; if not, please reopen