Closed
Bug 753542
Opened 9 years ago
Closed 9 years ago
Add prefs to enable/disable E4X (javascript.options.xml.content and .chrome)
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: jorendorff, Assigned: jorendorff)
References
Details
(Whiteboard: [js:p2])
Attachments
(1 file, 4 obsolete files)
12.52 KB,
patch
|
benjamin
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
The problem is that JSOPTION_XML doesn't do what you might guess, so I'm splitting it into two separate options: JSOPTION_ALLOW_XML - if this is off, we won't allow E4X syntax no matter what your version number is JSOPTION_MOAR_XML - if ALLOW_XML is off, this has no effect; if ALLOW_XML is on, this has the effect of the existing JSOPTION_XML flag, which means we allow E4X even in JS version numbers that don't normally have it, and <!-- is treated as an E4X comment rather than as a // to-end-of-line comment. This patch simply renames the existing JSOPTION_XML to JSOPTION_MOAR_XML, and a few other trivial renamings/cleanups. There should be no change in behavior.
Assignee: general → jorendorff
Assignee | ||
Comment 2•9 years ago
|
||
Adds JSOPTION_ALLOW_XML and unconditionally turns it on throughout the browser (and JS test suites except jsapi-tests).
Assignee | ||
Comment 3•9 years ago
|
||
This adds two prefs: javascript.options.xml.chrome javascript.options.xml.content Both these prefs control JSOPTION_ALLOW_XML. The first is for chrome JS; the second is for web content. In this patch, both default to true so as not to change the default behavior, but in a follow-up bug I intend to make them both off-by-default! Note: In this WIP, the prefs only control XML syntax; neither pref affects the constructors XML, XMLList, Namespace, etc. that exist in every global. Those shouldn't exist either, if JSOPTION_ALLOW_XML is off. I just haven't implemented that part yet.
Assignee | ||
Comment 4•9 years ago
|
||
Oh - I should add that due to bugs in part 2, this isn't passing tests yet. At the moment, it's disabling XML support more than it should. Just putting the patches up early so anyone interested could look into the effect on addons.
Updated•9 years ago
|
Whiteboard: [js:p2]
Assignee | ||
Comment 5•9 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=34c01d5ee00e
Assignee | ||
Comment 6•9 years ago
|
||
Attachment #624405 -
Attachment is obsolete: true
Attachment #624406 -
Attachment is obsolete: true
Attachment #624419 -
Attachment is obsolete: true
Assignee | ||
Comment 7•9 years ago
|
||
Sorry for the last-minute request. I'd like addon developers to be able to test their stuff using FF15 this release, and default the pref to false in FF16.
Attachment #626502 -
Attachment is obsolete: true
Attachment #628773 -
Flags: superreview?(jst)
Attachment #628773 -
Flags: review?(benjamin)
Assignee | ||
Comment 8•9 years ago
|
||
New Try run, since I added code: https://tbpl.mozilla.org/?tree=Try&rev=b96dd38052fa
Updated•9 years ago
|
Attachment #628773 -
Flags: superreview?(jst) → superreview+
Updated•9 years ago
|
Attachment #628773 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 9•9 years ago
|
||
Thank you for the rapid reviews! https://hg.mozilla.org/integration/mozilla-inbound/rev/ce0c716baefd
Comment 10•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ce0c716baefd
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
Updated•9 years ago
|
Blocks: ExactRooting
You need to log in
before you can comment on or make changes to this bug.
Description
•