753574 - Remove more dead code from the Android build system

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

Attachment: 1. Remove XUL feedback add-on and misc build files

Just removing a bunch of unused files and code paths.  This makes our code easier to search through, and might make it build faster.  It also fixes some build warnings.

Comment 1

[Matt Brubeck (:mbrubeck)]

Attachment: 2. Remove XULRunner support and clean up Makefiles

Comment 2

[Matt Brubeck (:mbrubeck)]

Attachment: 3. Remove platform-specific code for non-Android platforms

Comment 3

[Matt Brubeck (:mbrubeck)]

Attachment: 4. Remove nsShellService

Comment 4

[Matt Brubeck (:mbrubeck)]

Attachment: 4. Remove nsShellService (v2)

Oops, missed a line.

Comment 5

[:Margaret Leibovic]

Comment on attachment 622552 [details] [diff] [review]
3. Remove platform-specific code for non-Android platforms

Review of attachment 622552 [details] [diff] [review]:
-----------------------------------------------------------------

Drive-by...

::: mobile/android/components/DirectoryProvider.js
@@ -74,2 @@
>          default:
>            return profile;

We're not even checking the device here anymore, so it seems to me we can get rid of the code around this and just return profile.

Comment 6

[Matt Brubeck (:mbrubeck)]

I un-bitrotted the patches and added some changes suggested by Margaret.  They are green on Try:
https://tbpl.mozilla.org/?tree=Try&rev=bf5cd3be92d9

Comment 7

[Matt Brubeck (:mbrubeck)]

Many of these changes have now landed in bug 722042.

Comment 8

[Wesley Johnston (:wesj)]

Comment on attachment 622547 [details] [diff] [review]
1. Remove XUL feedback add-on and misc build files

Review of attachment 622547 [details] [diff] [review]:
-----------------------------------------------------------------

Can I steal?

Needs unbitrotting. A lot of this is already gone. content.js and preferences.js are still left behind after this (we added headers since your last update?). I'd be fine with removing the entire profile/extensions directory. Are we holding on to it just in case?

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

What here is still relevant?

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 622550 [details] [diff] [review]
2. Remove XULRunner support and clean up Makefiles

This patch is likely bitrotted, but the intent is good.

f+, but we should get a new patch for r+

Comment 11

[Nick Alexander :nalexander [he/him]]

I am going to say this is no longer relevant.