Closed
Bug 753607
Opened 13 years ago
Closed 13 years ago
Overhaul existing Marionette WebAPI tests
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: philikon, Assigned: philikon)
References
Details
Attachments
(1 file, 1 obsolete file)
24.59 KB,
patch
|
jgriffin
:
review+
jgriffin
:
feedback+
|
Details | Diff | Splinter Review |
We can now use new_sandbox = False to make the JS global handling a bit easier.
Assignee | ||
Comment 1•13 years ago
|
||
Also added the SMS test (which currently fails, so it's added as a known fail). Also got some weird failures in the battery tests and test_log.py. I suspect something isn't cleaning up properly...
Assignee: nobody → philipp
Attachment #622799 -
Flags: feedback?(jgriffin)
Assignee | ||
Comment 2•13 years ago
|
||
Rebased on top of bug 753606 v3
Attachment #622799 -
Attachment is obsolete: true
Attachment #622799 -
Flags: feedback?(jgriffin)
Attachment #622920 -
Flags: feedback?(jgriffin)
Comment 3•13 years ago
|
||
Comment on attachment 622920 [details] [diff] [review]
v2
lgtm; I'll file a followup bug to address the exception race condition that was causing test_battery.html to fail
Attachment #622920 -
Flags: feedback?(jgriffin) → feedback+
Assignee | ||
Comment 4•13 years ago
|
||
Comment on attachment 622920 [details] [diff] [review]
v2
Turns out, the test failure is due to a bug in Marionette which jgriffin already fixed, so I'm now submitting this for review.
Attachment #622920 -
Flags: review?(jgriffin)
Comment 5•13 years ago
|
||
Comment on attachment 622920 [details] [diff] [review]
v2
Review of attachment 622920 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good! Along with some of the other recent patches, here are the full test results:
SUMMARY
-------
passed: 55
failed: 0
todo: 0
We're obviously not calculating todo correctly, since we have two expected failures in this test set. I'll file a followup bug.
Attachment #622920 -
Flags: review?(jgriffin) → review+
Assignee | ||
Comment 6•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in
before you can comment on or make changes to this bug.
Description
•