Overhaul existing Marionette WebAPI tests

RESOLVED FIXED in mozilla15

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: philikon, Assigned: philikon)

Tracking

unspecified
mozilla15
ARM
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

We can now use new_sandbox = False to make the JS global handling a bit easier.
Created attachment 622799 [details] [diff] [review]
v1

Also added the SMS test (which currently fails, so it's added as a known fail). Also got some weird failures in the battery tests and test_log.py. I suspect something isn't cleaning up properly...
Assignee: nobody → philipp
Attachment #622799 - Flags: feedback?(jgriffin)
(Assignee)

Updated

5 years ago
Depends on: 753606
Created attachment 622920 [details] [diff] [review]
v2

Rebased on top of bug 753606 v3
Attachment #622799 - Attachment is obsolete: true
Attachment #622799 - Flags: feedback?(jgriffin)
Attachment #622920 - Flags: feedback?(jgriffin)
Comment on attachment 622920 [details] [diff] [review]
v2

lgtm; I'll file a followup bug to address the exception race condition that was causing test_battery.html to fail
Attachment #622920 - Flags: feedback?(jgriffin) → feedback+
Comment on attachment 622920 [details] [diff] [review]
v2

Turns out, the test failure is due to a bug in Marionette which jgriffin already fixed, so I'm now submitting this for review.
Attachment #622920 - Flags: review?(jgriffin)
Comment on attachment 622920 [details] [diff] [review]
v2

Review of attachment 622920 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! Along with some of the other recent patches, here are the full test results:

SUMMARY
-------
passed: 55
failed: 0
todo: 0

We're obviously not calculating todo correctly, since we have two expected failures in this test set. I'll file a followup bug.
Attachment #622920 - Flags: review?(jgriffin) → review+
https://hg.mozilla.org/mozilla-central/rev/7b5d636382b2
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.