753607 - Overhaul existing Marionette WebAPI tests

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Philipp von Weitershausen [:philikon]]

We can now use new_sandbox = False to make the JS global handling a bit easier.

Comment 1

[Philipp von Weitershausen [:philikon]]

Attachment: v1

Also added the SMS test (which currently fails, so it's added as a known fail). Also got some weird failures in the battery tests and test_log.py. I suspect something isn't cleaning up properly...

Comment 2

[Philipp von Weitershausen [:philikon]]

Attachment: v2

Rebased on top of bug 753606 v3

Comment 3

[Jonathan Griffin (:jgriffin)]

Comment on attachment 622920 [details] [diff] [review]
v2

lgtm; I'll file a followup bug to address the exception race condition that was causing test_battery.html to fail

Comment 4

[Philipp von Weitershausen [:philikon]]

Comment on attachment 622920 [details] [diff] [review]
v2

Turns out, the test failure is due to a bug in Marionette which jgriffin already fixed, so I'm now submitting this for review.

Comment 5

[Jonathan Griffin (:jgriffin)]

Comment on attachment 622920 [details] [diff] [review]
v2

Review of attachment 622920 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! Along with some of the other recent patches, here are the full test results:

SUMMARY
-------
passed: 55
failed: 0
todo: 0

We're obviously not calculating todo correctly, since we have two expected failures in this test set. I'll file a followup bug.

Comment 6

[Philipp von Weitershausen [:philikon]]

https://hg.mozilla.org/mozilla-central/rev/7b5d636382b2