The default bug view has changed. See this FAQ.

enable DumpHeapComplete in non-debug builds

RESOLVED FIXED in mozilla16

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

(Blocks: 2 bugs)

Trunk
mozilla16
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [js:t])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
With bug 701415 in place, I think we should be able to enable DumpHeapComplete in non-debug builds.  That should also include the XPConnect heap dumping code that calls it, as well as the CC's invocation of that code.
Whiteboard: [js:t]
(Assignee)

Comment 1

5 years ago
Created attachment 627298 [details] [diff] [review]
remove some ifdef DEBUGs
(Assignee)

Comment 2

5 years ago
Comment on attachment 627298 [details] [diff] [review]
remove some ifdef DEBUGs

Pretty simple patch.  Olli can look at the stuff in nsCycleCollector.cpp, Bill can review the rest.
Attachment #627298 - Flags: review?(wmccloskey)
Attachment #627298 - Flags: review?(bugs)
(Assignee)

Updated

5 years ago
Blocks: 759581

Updated

5 years ago
Attachment #627298 - Flags: review?(bugs) → review+
Comment on attachment 627298 [details] [diff] [review]
remove some ifdef DEBUGs

Review of attachment 627298 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsapi.cpp
@@ +2517,2 @@
>  JS_PUBLIC_API(void)
>  JS_PrintTraceThingInfo(char *buf, size_t bufsize, JSTracer *trc, void *thing,

While you're here, can you rename this to JS_GetTraceThingInfo?
Attachment #627298 - Flags: review?(wmccloskey) → review+
(Assignee)

Comment 4

5 years ago
Thanks for the quick reviews!  Try run looked good.  I renamed the function and fixed up comments in one or two places.

https://hg.mozilla.org/integration/mozilla-inbound/rev/9efa5af3c1d8
Assignee: general → continuation
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/9efa5af3c1d8
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Excellent! I've been waiting for this.

So, it should be in today's Nightly, correct?

Honza
(Assignee)

Comment 7

5 years ago
No, it will be in tomorrow's.

I previously switched on JS details in cycle collector dumps, this is just the final trivial bit to enable producing JS heap dumps, too.
You need to log in before you can comment on or make changes to this bug.