Closed
Bug 753614
Opened 12 years ago
Closed 11 years ago
enable DumpHeapComplete in non-debug builds
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: mccr8, Assigned: mccr8)
References
(Blocks 1 open bug)
Details
(Whiteboard: [js:t])
Attachments
(1 file)
7.68 KB,
patch
|
billm
:
review+
smaug
:
review+
|
Details | Diff | Splinter Review |
With bug 701415 in place, I think we should be able to enable DumpHeapComplete in non-debug builds. That should also include the XPConnect heap dumping code that calls it, as well as the CC's invocation of that code.
Updated•12 years ago
|
Whiteboard: [js:t]
Assignee | ||
Comment 1•12 years ago
|
||
Assignee | ||
Comment 2•11 years ago
|
||
Comment on attachment 627298 [details] [diff] [review] remove some ifdef DEBUGs Pretty simple patch. Olli can look at the stuff in nsCycleCollector.cpp, Bill can review the rest.
Attachment #627298 -
Flags: review?(wmccloskey)
Attachment #627298 -
Flags: review?(bugs)
Updated•11 years ago
|
Attachment #627298 -
Flags: review?(bugs) → review+
Comment on attachment 627298 [details] [diff] [review] remove some ifdef DEBUGs Review of attachment 627298 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/jsapi.cpp @@ +2517,2 @@ > JS_PUBLIC_API(void) > JS_PrintTraceThingInfo(char *buf, size_t bufsize, JSTracer *trc, void *thing, While you're here, can you rename this to JS_GetTraceThingInfo?
Attachment #627298 -
Flags: review?(wmccloskey) → review+
Assignee | ||
Comment 4•11 years ago
|
||
Thanks for the quick reviews! Try run looked good. I renamed the function and fixed up comments in one or two places. https://hg.mozilla.org/integration/mozilla-inbound/rev/9efa5af3c1d8
Assignee: general → continuation
Target Milestone: --- → mozilla16
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9efa5af3c1d8
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 6•11 years ago
|
||
Excellent! I've been waiting for this. So, it should be in today's Nightly, correct? Honza
Assignee | ||
Comment 7•11 years ago
|
||
No, it will be in tomorrow's. I previously switched on JS details in cycle collector dumps, this is just the final trivial bit to enable producing JS heap dumps, too.
You need to log in
before you can comment on or make changes to this bug.
Description
•