Closed
Bug 753615
Opened 14 years ago
Closed 14 years ago
Ensure we don't re-enter a GC phase
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: billm, Assigned: billm)
Details
Attachments
(1 file)
|
2.80 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
I noticed that the times from the error console were screwy in some cases. The problem is that we tell the statistics code that we're entering the mark phase, and then tell it again a little later. The code isn't designed to handle re-entry.
This patch asserts that we never re-enter a phase. It also fixes the case I found, where IncrementalMarkSlice enters the mark phase, and then re-enters it in EndMarkPhase.
Attachment #622598 -
Flags: review?(terrence)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 622598 [details] [diff] [review]
patch
Review of attachment 622598 [details] [diff] [review]:
-----------------------------------------------------------------
Good catch.
Attachment #622598 -
Flags: review?(terrence) → review+
|
Assignee | |
Comment 2•14 years ago
|
||
Target Milestone: --- → mozilla15
|
||
Comment 3•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•