Ensure we don't re-enter a GC phase

RESOLVED FIXED in mozilla15

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: billm, Assigned: billm)

Tracking

unspecified
mozilla15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 622598 [details] [diff] [review]
patch

I noticed that the times from the error console were screwy in some cases. The problem is that we tell the statistics code that we're entering the mark phase, and then tell it again a little later. The code isn't designed to handle re-entry.

This patch asserts that we never re-enter a phase. It also fixes the case I found, where IncrementalMarkSlice enters the mark phase, and then re-enters it in EndMarkPhase.
Attachment #622598 - Flags: review?(terrence)
Comment on attachment 622598 [details] [diff] [review]
patch

Review of attachment 622598 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch.
Attachment #622598 - Flags: review?(terrence) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/a8b9ad3204ab
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/a8b9ad3204ab
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.