Bug 753623 (CVE-2012-3971)

Graphite 2 crash [@graphite2::Pass::readPass]

VERIFIED FIXED in Firefox 15

Status

()

Core
Graphics
--
critical
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: posidron, Assigned: jfkthame)

Tracking

(Blocks: 1 bug, {crash, sec-high, testcase})

Trunk
mozilla15
x86_64
Mac OS X
crash, sec-high, testcase
Points:
---

Firefox Tracking Flags

(firefox14+ affected, firefox15+ fixed, firefox16+ fixed, firefox-esr10 unaffected)

Details

(Whiteboard: [asan][sg:high][advisory-tracking+])

Attachments

(4 attachments, 1 obsolete attachment)

(Reporter)

Description

5 years ago
Created attachment 622603 [details]
testcase
(Reporter)

Comment 1

5 years ago
Created attachment 622604 [details]
callstack

Comment 2

5 years ago
I was unable to replicate this bug with valgrind and gr2fonttest (how I normally replicate such bugs). But a visual review of that area of the code has resulted in my tightening some checks. These have been pushed into the upstream repo. This bug will need to be retested when the patch with this repo version in is applied to your code. (repo version: 976 (d74a1988ba08))
What are our plans to update the mozilla version of Graphite2 to the latest upstream?
Assignee: nobody → jfkthame
status-firefox15: --- → affected
Keywords: sec-high
(Assignee)

Comment 4

5 years ago
We've just updated Graphite2 in bug 753230. Christoph, could you re-test this with a build that includes that patch, and confirm whether it's fixed? Thanks!
(Reporter)

Comment 5

5 years ago
This bug here is still reproducible.
(Assignee)

Comment 6

5 years ago
Is the call stack still identical to comment #1, or have line numbers etc possibly shifted at all in the Graphite update? If you could post a fresh call stack to confirm exactly where it's occurring, I'll try to take a look.
(Reporter)

Comment 7

5 years ago
Created attachment 628091 [details]
fresh-callstack

Have a attach a fresh callstack.

Comment 8

5 years ago
Fix committed to upstream repository. Planning to do a release later today. BTW the latest valgrind has no exp-ptrcheck and exp-sgcheck doesn't trigger on this fault :(
(Assignee)

Comment 9

5 years ago
Created attachment 628290 [details] [diff] [review]
patch from upstream

This is the relevant patch from the upstream repo - Christoph, if you have a chance to try this and confirm that it fixes the issue, that'd be great.

(Not requesting review on this for now as I plan to take the complete new release when it's ready in the next day or so, but in the meantime any testing would be welcome.)
Attachment #628290 - Flags: feedback?(cdiehl)
(Assignee)

Comment 10

5 years ago
Created attachment 628304 [details] [diff] [review]
update graphite2 to release 1.1.3

Version 1.1.3 has now been released upstream, so here's the patch to update our copy to the new version, which includes the fix for this bug.
Attachment #628290 - Attachment is obsolete: true
Attachment #628290 - Flags: feedback?(cdiehl)
Attachment #628304 - Flags: review?(jdaggett)
Attachment #628304 - Flags: feedback?(cdiehl)
(Reporter)

Comment 11

5 years ago
Comment on attachment 628304 [details] [diff] [review]
update graphite2 to release 1.1.3

Review of attachment 628304 [details] [diff] [review]:
-----------------------------------------------------------------

Tested with the provieded patch, fixed!
Attachment #628304 - Flags: feedback?(cdiehl) → feedback+

Comment 12

5 years ago
Comment on attachment 628304 [details] [diff] [review]
update graphite2 to release 1.1.3

If possible, having a crashtest for this would be nice.
Attachment #628304 - Flags: review?(jdaggett) → review+
(Assignee)

Comment 13

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/1446e5aba066

Not sure about a crashtest - the issue only showed up under ASAN, not as a crash with a normal browser build (though in principle it could've crashed if the out-of-bounds access happened to hit an unmapped page, or something like that).

Maybe we should be running unit tests with ASAN builds, at least on a daily basis if not per-push? I expect that'd flush out some issues...
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/1446e5aba066
Status: NEW → RESOLVED
Last Resolved: 5 years ago
status-firefox15: affected → fixed
Resolution: --- → FIXED
(Reporter)

Updated

5 years ago
Status: RESOLVED → VERIFIED
We need these fixes in Beta (Fx14), right? Please request approval on the patch unless it's too risky to consider. (This may not be the only bug or security bug fixed upstream).
status-firefox-esr10: --- → unaffected
status-firefox14: --- → affected
status-firefox16: --- → fixed
tracking-firefox14: --- → +
tracking-firefox15: --- → +
tracking-firefox16: --- → +
Whiteboard: [asan][sg:high] → [asan][sg:high][advisory-tracking+]
Alias: CVE-2012-3971
Group: core-security
You need to log in before you can comment on or make changes to this bug.