Closed Bug 753625 Opened 8 years ago Closed 8 years ago

Fennec can get into a session restore crash loop

Categories

(Firefox for Android :: General, defect)

13 Branch
ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 15
Tracking Status
firefox14 --- fixed
blocking-fennec1.0 --- betaN+

People

(Reporter: bnicholson, Assigned: bnicholson)

References

Details

(Keywords: regression, Whiteboard: [has proposed patch])

Attachments

(1 file)

This was originally fixed by bug 701092, but was regressed by bug 718240. We moved the restore logic into Java, which sets the forceRestore flag to true whenever we should restore. However, this doesn't distinguish between whether we crashed or are OOM-killed, and aForceRestore is always true here: http://mxr.mozilla.org/mozilla-central/source/mobile/android/components/SessionStore.js#924.
Blocks: 718240
Keywords: regression
Version: unspecified → Firefox 13
blocking-fennec1.0: --- → ?
Assignee: nobody → bnicholson
blocking-fennec1.0: ? → betaN+
Summary: Fennec can crash loop → Fennec can get into a session restore crash loop
Attached patch patchSplinter Review
Use tri-state session restore flag so we can still bail for crashes.
Attachment #623737 - Flags: review?(mark.finkle)
Comment on attachment 623737 [details] [diff] [review]
patch


>diff --git a/mobile/android/base/GeckoThread.java b/mobile/android/base/GeckoThread.java

>+    GeckoThread (Intent intent, String uri, int restoreSession) {

nit: remove the space in "GeckoThread ("

>diff --git a/mobile/android/chrome/content/browser.js b/mobile/android/chrome/content/browser.js

>-    let forceRestore = false;
>+    let restoreType = 0;

nit: you use mRestoreSession in Java. Could we use "restoreSession" here? My next favorite name is "restoreMode"
Attachment #623737 - Flags: review?(mark.finkle) → review+
Whiteboard: [has proposed patch]
Changed instances of "restoreSession" to "restoreMode".

http://hg.mozilla.org/integration/mozilla-inbound/rev/b776bb82fb4a
https://hg.mozilla.org/mozilla-central/rev/b776bb82fb4a
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 15
Comment on attachment 623737 [details] [diff] [review]
patch

[Triage Comment]
Attachment #623737 - Flags: approval-mozilla-aurora+
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.