753625 - Fennec can get into a session restore crash loop

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Brian Nicholson (:bnicholson)]

This was originally fixed by bug 701092, but was regressed by bug 718240. We moved the restore logic into Java, which sets the forceRestore flag to true whenever we should restore. However, this doesn't distinguish between whether we crashed or are OOM-killed, and aForceRestore is always true here: http://mxr.mozilla.org/mozilla-central/source/mobile/android/components/SessionStore.js#924.

Comment 2

[Brian Nicholson (:bnicholson)]

Attachment: patch

Use tri-state session restore flag so we can still bail for crashes.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 623737 [details] [diff] [review]
patch


>diff --git a/mobile/android/base/GeckoThread.java b/mobile/android/base/GeckoThread.java

>+    GeckoThread (Intent intent, String uri, int restoreSession) {

nit: remove the space in "GeckoThread ("

>diff --git a/mobile/android/chrome/content/browser.js b/mobile/android/chrome/content/browser.js

>-    let forceRestore = false;
>+    let restoreType = 0;

nit: you use mRestoreSession in Java. Could we use "restoreSession" here? My next favorite name is "restoreMode"

Comment 4

[Brian Nicholson (:bnicholson)]

Changed instances of "restoreSession" to "restoreMode".

http://hg.mozilla.org/integration/mozilla-inbound/rev/b776bb82fb4a

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b776bb82fb4a

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 623737 [details] [diff] [review]
patch

[Triage Comment]

Comment 7

[Brian Nicholson (:bnicholson)]

http://hg.mozilla.org/releases/mozilla-aurora/rev/912f2f925469