Closed
Bug 753854
Opened 12 years ago
Closed 12 years ago
-[NSOpenGLPixelFormat initWithAttributes] should be passed a 0 terminated array
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: zpao, Assigned: zpao)
Details
Attachments
(1 file)
|
1.11 KB,
patch
|
joe
:
review+
|
Details | Diff | Splinter Review |
This may be a 10.8/clang only issue, but when I tried to build yesterday, I got an error when casting nil to NSOpenGLPixelFormatAttribute (aka unsigned int). That's being used to terminate the array of attributes. According to the docs, -[NSOpenGLPixelFormat initWithAttributes] expects a 0 terminated array which we aren't explicitly doing in a couple cases - instead we're casting nil. We do end up doing this correctly later in GLContextProviderCGL.mm
Attachment #622768 -
Flags: review?(joe)
|
||
Updated•12 years ago
|
Attachment #622768 -
Flags: review?(joe) → review+
|
Assignee | |
Comment 1•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/cf7058f714fd
Assignee: nobody → paul
Target Milestone: --- → mozilla15
|
|
||
Comment 2•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cf7058f714fd
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•