-[NSOpenGLPixelFormat initWithAttributes] should be passed a 0 terminated array

RESOLVED FIXED in mozilla15

Status

()

Core
Graphics
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: zpao, Assigned: zpao)

Tracking

unspecified
mozilla15
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 622768 [details] [diff] [review]
Patch v0.1

This may be a 10.8/clang only issue, but when I tried to build yesterday, I got an error when casting nil to NSOpenGLPixelFormatAttribute (aka unsigned int). That's being used to terminate the array of attributes.

According to the docs, -[NSOpenGLPixelFormat initWithAttributes] expects a 0 terminated array which we aren't explicitly doing in a couple cases - instead we're casting nil.

We do end up doing this correctly later in GLContextProviderCGL.mm
Attachment #622768 - Flags: review?(joe)
Attachment #622768 - Flags: review?(joe) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/cf7058f714fd
Assignee: nobody → paul
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/cf7058f714fd
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.