Last Comment Bug 753854 - -[NSOpenGLPixelFormat initWithAttributes] should be passed a 0 terminated array
: -[NSOpenGLPixelFormat initWithAttributes] should be passed a 0 terminated array
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: mozilla15
Assigned To: Paul O'Shannessy [:zpao] (not reading much bugmail, email directly)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-10 10:00 PDT by Paul O'Shannessy [:zpao] (not reading much bugmail, email directly)
Modified: 2012-05-10 18:28 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v0.1 (1.11 KB, patch)
2012-05-10 10:00 PDT, Paul O'Shannessy [:zpao] (not reading much bugmail, email directly)
joe: review+
Details | Diff | Review

Description Paul O'Shannessy [:zpao] (not reading much bugmail, email directly) 2012-05-10 10:00:49 PDT
Created attachment 622768 [details] [diff] [review]
Patch v0.1

This may be a 10.8/clang only issue, but when I tried to build yesterday, I got an error when casting nil to NSOpenGLPixelFormatAttribute (aka unsigned int). That's being used to terminate the array of attributes.

According to the docs, -[NSOpenGLPixelFormat initWithAttributes] expects a 0 terminated array which we aren't explicitly doing in a couple cases - instead we're casting nil.

We do end up doing this correctly later in GLContextProviderCGL.mm
Comment 1 Paul O'Shannessy [:zpao] (not reading much bugmail, email directly) 2012-05-10 13:16:52 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/cf7058f714fd
Comment 2 Joe Drew (not getting mail) 2012-05-10 18:28:26 PDT
https://hg.mozilla.org/mozilla-central/rev/cf7058f714fd

Note You need to log in before you can comment on or make changes to this bug.