75391 - TODO list for folder pane outliner

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Comment 1

[Jan Varga [:janv]]

Ok so here is list of remaining functions:

commandglue.js
- SortFolderPane()

mail3PaneWindowCommands.js
- FillInFolderTooltip()

messengerdnd.js
- all

msgMail3PaneWindow.js
- PerformExpandForAllOpenServers()
- GetSelectedFolder()
- FolderPaneOnClick()
- FolderPaneDoubleClick()

widgetglue.js
MsgEmptyTrash()
MsgCompactFolder()


Next, we need define new style rules for folder outliner.

And I don't know yet how we will store informations about each folder
(sort key, sort direction, scroll position, etc)

Comment 2

[Jan Varga [:janv]]

Question probably for waterson...
Now I can do this:

<outliner>
 <outlinercol id="folderNameCol" flex="1" primary="true"/>
 <outlinerbody id="folderOutlinerBody" flex="1"
               datasources="rdf:null">
  <template>
   <outlinerrow uri="...">
    <outlinercell ref="folderNameCol"
                  label="rdf:http://home.netscape.com/NC-rdf#FolderTreeName"   
              properties="rdf:http://home.netscape.com/NC-rdf#IsServer"/>
   </outlinerrow>
  </template>
 </outlinerbody>
</outliner>

outlinerbody:-moz-outliner-image(folderNameCol, true) {
  list-style-image: url("chrome://messenger/skin/server-mail.gif");
}


but I would like:

outlinerbody:-moz-outliner-image(folderNameCol, isServer) {
  list-style-image: url("chrome://messenger/skin/server-mail.gif");
}


Is it possible without touching folder datasource code ?

Comment 3

[Jan Varga [:janv]]

Log from irc:

*hwaara* this is what we need done (please add things), some may already be
+done:
*hwaara* * Hook up selection so it loads the folder
*hwaara* * Hook up image loading
*hwaara* * Fix it so we display a newmail icon on the folder/inbox if it has
+new mail
*hwaara* * Make doubleclicking work
*hwaara* * Fix DND of folders and to folders (with messages)
*hwaara* * Hook up stuff like SpecialFolders (this was previously done by
+accessing RDF)..

Comment 4

[Jan Varga [:janv]]

Folder images should be fixed now.


Answer for my previous question:

properties="isServer-rdf:http://home.netscape.com/NC-rdf#IsServer"

outlinerbody:-moz-outliner-image(folderNameCol, isServer-true) {
  list-style-image: url("chrome://messenger/skin/server-mail.gif");
}

Comment 5

[Jan Varga [:janv]]

I forgot to notice, images work only with Classic theme

Comment 6

[Jan Varga [:janv]]

Someone can fix Modern.

Comment 7

[Jan Varga [:janv]]

Folder tooltips now work.

Comment 8

[Jan Varga [:janv]]

Persistence now works too.

Comment 9

[Jan Varga [:janv]]

Images in Modern fixed.

Comment 10

[Håkan Waara]

Yes it is. I also hooked up all the other style attributes, so folders
containing new messages are bold (and all that).

The folderpane is now working properly in Modern.

Jan, will you fix Classic for all platforms? As far as I could see, you only
fixed Windows.

Comment 11

[Jan Varga [:janv]]

We only need rewrite mac/folderPane.css in Classic

Comment 12

[Jan Varga [:janv]]

I rewrote mac/folderPane.css. Someone should test it.

Comment 13

[Jan Varga [:janv]]

dnd - roughly fixed

Comment 14

[(not reading, please use [e-mail] instead)]

nbaca, this bug would block your "folder pane not redrawing" bug.

Comment 15

[Håkan Waara]

Now the UI looks almost exactly as usual - we fixed the rowheight and aligning
of icons. I'm using it as dogfood now, and it works quite smooth with only a few
glitches.

Comment 16

[(not reading, please use [e-mail] instead)]

bienvenu might be fixing the peristence issue for you as part of another bug.

Comment 17

[David :Bienvenu]

I'm adding the ability to store sort order, sort type, view type, and view flags
in the db - this work is orthogonal to your outliner work - I'll be removing the
persistence of these from the existing tree code and adding js code to get and
set these values. That work is covered in bug 12896. But we'll still need a way
to persist the expand/collapse state of each parent folder so that it is
remembered across sessions. One way would be use MSG_FOLDER_FLAG_ELIDED and
set/clear that flag on the nsIMsgFolder when we collapse/expand folders, but
Seth was talking about needing some generic way to persist this from the
outliner (other than localstore.rdf, or I won't be able to fix 12896).

Comment 18

[(not reading, please use [e-mail] instead)]

right, it seems like this would be a generic problem for all rdf-outliners.

bryner, did you have to deal with this for the new file picker, or is that not
using the file datasource?

Comment 19

[Jan Varga [:janv]]

Ok, but I thought that we want generic way to store attributes.

Comment 20

[David :Bienvenu]

Not sure who you're responding to, Jan, but a generic way to store attributes
would be fine - however, if it uses localstore.rdf, we can't use it for the
folder pane if we want to fix bug 12896. And I've been told that's a very high
priority bug so I'm trying to fix that ASAP.

Comment 21

[Jan Varga [:janv]]

Now I understand.
So persistence in this special case will be fixed using message database to
avoid touching localstore.rdf.
Sounds good.

Thanks.

Comment 22

[Jan Varga [:janv]]

All items of this bug fixed.

Comment 23

[David :Bienvenu]

Are we thinking of trying to land this branch for .9.2?

Comment 24

[Håkan Waara]

bienvenu, 73865 is the real bug. this was just for us to plot down our notes.

Comment 25

[[e-mail] (gone - use [e-mail] instead)]

Since you guys have marked this fixed, and it's just a "note-taking" bug, there
is no harm in verifying.  Besides, this is planned on beginning the reviewal
process this Monday the 16th of July.  Verified.