Last Comment Bug 754089 - remote mozbrowser's messagemanager shouldn't have parent
: remote mozbrowser's messagemanager shouldn't have parent
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: unspecified
: x86_64 Linux
: -- normal (vote)
: ---
Assigned To: Olli Pettay [:smaug] (vacation Aug 25-28)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-10 15:37 PDT by Olli Pettay [:smaug] (vacation Aug 25-28)
Modified: 2012-05-11 01:29 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (4.58 KB, patch)
2012-05-10 16:43 PDT, Olli Pettay [:smaug] (vacation Aug 25-28)
justin.lebar+bug: review+
Details | Diff | Splinter Review

Description Olli Pettay [:smaug] (vacation Aug 25-28) 2012-05-10 15:37:40 PDT
The normal messagemanager have a tree
global->window->tab
We don't want mozbrowser mm to show up there.
Comment 1 Olli Pettay [:smaug] (vacation Aug 25-28) 2012-05-10 15:42:20 PDT
http://hg.mozilla.org/mozilla-central/diff/9d00516b0ad7/content/base/src/nsFrameLoader.cpp#l1.191
is wrong.
mozbrowser mm just shouldn't have a parent
Comment 2 Olli Pettay [:smaug] (vacation Aug 25-28) 2012-05-10 16:43:42 PDT
Created attachment 622966 [details] [diff] [review]
patch

I changed also the OwnerDoc() to GetOwnerDoc() to follow the coding style
(Get* may return null).
Comment 3 Olli Pettay [:smaug] (vacation Aug 25-28) 2012-05-10 16:47:41 PDT
https://tbpl.mozilla.org/?tree=Try&rev=88869810096c
Comment 4 Justin Lebar (not reading bugmail) 2012-05-10 23:35:44 PDT
Comment on attachment 622966 [details] [diff] [review]
patch

Ah, I think I understand now.  r=me.  :)
Comment 5 Olli Pettay [:smaug] (vacation Aug 25-28) 2012-05-11 01:29:38 PDT
https://hg.mozilla.org/mozilla-central/rev/3670d1eb1b31

Note You need to log in before you can comment on or make changes to this bug.