Comment 1 David Zbarsky (:dzbarsky) 2012-05-12 17:11:49 PDT

Created attachment 623467 [details] [diff] [review]
Patch r=roc

Comment 2 Bas Schouten (:bas.schouten) 2012-05-12 21:00:00 PDT

Comment on attachment 623467 [details] [diff] [review]
Patch r=roc

Review of attachment 623467 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/2d/Rect.h
@@ +88,5 @@
>      {
>        *aOut = IntRect(int32_t(X()), int32_t(Y()),
>                      int32_t(Width()), int32_t(Height()));
> +      return Rect(float(aOut->x), float(aOut->y), 
> +                  float(aOut->width), float(aOut->height)).IsEqualEdges(*this);

I'd suggest using Float, the actual type of Rect().

Comment 3 Ryan VanderMeulen [:RyanVM] 2012-05-14 15:57:13 PDT

Comment on attachment 623467 [details] [diff] [review]
Patch r=roc

You can just use checkin-needed for single-patch bugs like this.

Comment 4 Ryan VanderMeulen [:RyanVM] 2012-05-14 16:02:21 PDT

Pushed with comment 2 addressed.

https://hg.mozilla.org/integration/mozilla-inbound/rev/0623ff91509e

Comment 5 Ed Morley [:emorley] 2012-05-15 06:34:05 PDT

https://hg.mozilla.org/mozilla-central/rev/0623ff91509e