754138 - Rect.h generates lots of warnings when building content and layout

Status: RESOLVED FIXED

Description

[David Zbarsky (:dzbarsky)]

Created attachment 622995 [details] [diff] [review]
Patch

I haven't run this on tryserver yet because my account is disabled, but I will as soon as I can.

Comment 1

[David Zbarsky (:dzbarsky)]

Created attachment 623467 [details] [diff] [review]
Patch r=roc

Comment 2

[Bas Schouten (:bas.schouten)]

Comment on attachment 623467 [details] [diff] [review]
Patch r=roc

Review of attachment 623467 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/2d/Rect.h
@@ +88,5 @@
>      {
>        *aOut = IntRect(int32_t(X()), int32_t(Y()),
>                      int32_t(Width()), int32_t(Height()));
> +      return Rect(float(aOut->x), float(aOut->y), 
> +                  float(aOut->width), float(aOut->height)).IsEqualEdges(*this);

I'd suggest using Float, the actual type of Rect().

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 623467 [details] [diff] [review]
Patch r=roc

You can just use checkin-needed for single-patch bugs like this.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Pushed with comment 2 addressed.

https://hg.mozilla.org/integration/mozilla-inbound/rev/0623ff91509e

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/0623ff91509e