Closed
Bug 754138
Opened 9 years ago
Closed 9 years ago
Rect.h generates lots of warnings when building content and layout
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: dzbarsky, Assigned: dzbarsky)
Details
Attachments
(1 file, 1 obsolete file)
848 bytes,
patch
|
bas.schouten
:
review+
|
Details | Diff | Splinter Review |
I haven't run this on tryserver yet because my account is disabled, but I will as soon as I can.
Assignee | ||
Updated•9 years ago
|
OS: Windows 7 → All
Hardware: x86 → All
Version: unspecified → Trunk
Assignee | ||
Updated•9 years ago
|
Attachment #622995 -
Attachment is patch: true
Attachment #622995 -
Flags: review?(roc)
Attachment #622995 -
Flags: review?(roc) → review+
Assignee | ||
Comment 1•9 years ago
|
||
Assignee: nobody → dzbarsky
Attachment #622995 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #623467 -
Flags: checkin?
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 2•9 years ago
|
||
Comment on attachment 623467 [details] [diff] [review] Patch r=roc Review of attachment 623467 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/2d/Rect.h @@ +88,5 @@ > { > *aOut = IntRect(int32_t(X()), int32_t(Y()), > int32_t(Width()), int32_t(Height())); > + return Rect(float(aOut->x), float(aOut->y), > + float(aOut->width), float(aOut->height)).IsEqualEdges(*this); I'd suggest using Float, the actual type of Rect().
Attachment #623467 -
Flags: review+
Comment 3•9 years ago
|
||
Comment on attachment 623467 [details] [diff] [review] Patch r=roc You can just use checkin-needed for single-patch bugs like this.
Attachment #623467 -
Flags: checkin?
Comment 4•9 years ago
|
||
Pushed with comment 2 addressed. https://hg.mozilla.org/integration/mozilla-inbound/rev/0623ff91509e
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0623ff91509e
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•