The default bug view has changed. See this FAQ.

Rect.h generates lots of warnings when building content and layout

RESOLVED FIXED in mozilla15

Status

()

Core
Graphics
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dzbarsky, Assigned: dzbarsky)

Tracking

Trunk
mozilla15
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 622995 [details] [diff] [review]
Patch

I haven't run this on tryserver yet because my account is disabled, but I will as soon as I can.
(Assignee)

Updated

5 years ago
OS: Windows 7 → All
Hardware: x86 → All
Version: unspecified → Trunk
(Assignee)

Updated

5 years ago
Attachment #622995 - Attachment is patch: true
Attachment #622995 - Flags: review?(roc)
Attachment #622995 - Flags: review?(roc) → review+
(Assignee)

Comment 1

5 years ago
Created attachment 623467 [details] [diff] [review]
Patch r=roc
Assignee: nobody → dzbarsky
Attachment #622995 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #623467 - Flags: checkin?
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Comment on attachment 623467 [details] [diff] [review]
Patch r=roc

Review of attachment 623467 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/2d/Rect.h
@@ +88,5 @@
>      {
>        *aOut = IntRect(int32_t(X()), int32_t(Y()),
>                      int32_t(Width()), int32_t(Height()));
> +      return Rect(float(aOut->x), float(aOut->y), 
> +                  float(aOut->width), float(aOut->height)).IsEqualEdges(*this);

I'd suggest using Float, the actual type of Rect().
Attachment #623467 - Flags: review+
Comment on attachment 623467 [details] [diff] [review]
Patch r=roc

You can just use checkin-needed for single-patch bugs like this.
Attachment #623467 - Flags: checkin?
Pushed with comment 2 addressed.

https://hg.mozilla.org/integration/mozilla-inbound/rev/0623ff91509e
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/0623ff91509e
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.