754139 - Some NSS source files do not have the MPL 2.0 license

Status: RESOLVED FIXED

(NSS :: Build, defect, P2)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

I noticed that these files under mozilla/security/nss have issues with the license block:

* ocspd-certs.sh, jss_dll_versions.sh, dll_version.sh
	* No license

* dtlscon.c: using old tri-license

* mozilla/security/nss/cmd/addbuiltin/addbuiltin.c
	* Contains old MPL/GPL/LGPL header block

* test_socket.c, test_httpcertstore.c
	* Contains Sun License

IMO, it is a particularly good idea to make sure we understand how the files with the non-MPL Sun license are licensed to us, because of Oracle vs. Google.

Note: There are likely more files with issues; these are just ones I came across as part of making the patch for bug 754136.

Comment 1

[Gervase Markham [:gerv]]

> nss/tests/chains/ocspd-config/ocspd-certs.sh
> (I can't find a jss_dll_versions.sh)
> nss/tests/dll_version.sh

Despite the best efforts of my scripts, many files still don't have licence blocks; feel free to add them if you'd like.

> nss/lib/ssl/dtlscon.c
> nss/cmd/addbuiltin/addbuiltin.c

These need fixing.

> nss/cmd/libpkix/pkix_pl/module/test_socket.c
> nss/cmd/libpkix/pkix_pl/module/test_httpcertstore.c

These are BSD licences; that's fine. It doesn't matter that Sun is the copyright holder (unless they contain patented algorithms and Oracle sues...)

Gerv

Comment 2

[Gervase Markham [:gerv]]

Attachment: Patch v.1

Here's the remaining ones I could find with a grep.

Gerv

Comment 3

[Gervase Markham [:gerv]]

bsmith: review ping? This shouldn't be too complex...

Gerv

Comment 4

[Gervase Markham [:gerv]]

Checking in nss/cmd/addbuiltin/addbuiltin.c;
/cvsroot/mozilla/security/nss/cmd/addbuiltin/addbuiltin.c,v  <--  addbuiltin.c
new revision: 1.19; previous revision: 1.18
done
Checking in nss/lib/ssl/dtlscon.c;
/cvsroot/mozilla/security/nss/lib/ssl/dtlscon.c,v  <--  dtlscon.c
new revision: 1.3; previous revision: 1.2
done
Checking in nss/lib/ckfw/ckapi.perl;
/cvsroot/mozilla/security/nss/lib/ckfw/ckapi.perl,v  <--  ckapi.perl
new revision: 1.11; previous revision: 1.10
done
Checking in nss/lib/ckfw/builtins/certdata.perl;
/cvsroot/mozilla/security/nss/lib/ckfw/builtins/certdata.perl,v  <--  certdata.perl
new revision: 1.15; previous revision: 1.14
done
Checking in coreconf/mkdepend/Makefile;
/cvsroot/mozilla/security/coreconf/mkdepend/Makefile,v  <--  Makefile
new revision: 1.2; previous revision: 1.1
done

Gerv