Last Comment Bug 754244 - xpidl parses long longValue as long long Value
: xpidl parses long longValue as long long Value
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: XPCOM (show other bugs)
: 12 Branch
: x86 Mac OS X
: -- normal (vote)
: mozilla15
Assigned To: Benjamin Smedberg AWAY UNTIL 2-AUG-2016 [:bsmedberg]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-11 06:02 PDT by Darius Samerotte
Modified: 2012-05-18 18:25 PDT (History)
4 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Parse multi-word identifier tokens correctly, rev. 1 (1.16 KB, patch)
2012-05-11 09:22 PDT, Benjamin Smedberg AWAY UNTIL 2-AUG-2016 [:bsmedberg]
khuey: review+
Details | Diff | Splinter Review

Description Darius Samerotte 2012-05-11 06:02:56 PDT
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_3) AppleWebKit/536.5 (KHTML, like Gecko) Chrome/19.0.1084.41 Safari/536.5

Steps to reproduce:

Picked up work on a very old project and moved to the new python based xpidl after grabbing XULRunner 12.


Actual results:

It appears that the lexer chokes on:

attribute long longValue;

which generates:

  /* attribute long long Value; */
  NS_SCRIPTABLE NS_IMETHOD GetValue(PRInt64 *aValue) = 0;
  NS_SCRIPTABLE NS_IMETHOD SetValue(PRInt64 aValue) = 0;


Expected results:

Of course, this actually a long type named longValue, which worked fine with the old binary build.

I tried unsigned long long, expecting it to break as well, and sure enough, it did.
Comment 1 Benjamin Smedberg AWAY UNTIL 2-AUG-2016 [:bsmedberg] 2012-05-11 09:12:29 PDT
That's bizarre!
Comment 2 Benjamin Smedberg AWAY UNTIL 2-AUG-2016 [:bsmedberg] 2012-05-11 09:22:15 PDT
Created attachment 623182 [details] [diff] [review]
Parse multi-word identifier tokens correctly, rev. 1
Comment 3 Benjamin Smedberg AWAY UNTIL 2-AUG-2016 [:bsmedberg] 2012-05-18 13:07:24 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/be715fe9c916
Comment 4 Ryan VanderMeulen [:RyanVM] 2012-05-18 18:25:24 PDT
https://hg.mozilla.org/mozilla-central/rev/be715fe9c916

Note You need to log in before you can comment on or make changes to this bug.