754244 - xpidl parses long longValue as long long Value

Status: RESOLVED FIXED

Description

[Darius Samerotte]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_3) AppleWebKit/536.5 (KHTML, like Gecko) Chrome/19.0.1084.41 Safari/536.5

Steps to reproduce:

Picked up work on a very old project and moved to the new python based xpidl after grabbing XULRunner 12.


Actual results:

It appears that the lexer chokes on:

attribute long longValue;

which generates:

  /* attribute long long Value; */
  NS_SCRIPTABLE NS_IMETHOD GetValue(PRInt64 *aValue) = 0;
  NS_SCRIPTABLE NS_IMETHOD SetValue(PRInt64 aValue) = 0;


Expected results:

Of course, this actually a long type named longValue, which worked fine with the old binary build.

I tried unsigned long long, expecting it to break as well, and sure enough, it did.

Comment 1

[Benjamin Smedberg]

That's bizarre!

Comment 2

[Benjamin Smedberg]

Created attachment 623182 [details] [diff] [review]
Parse multi-word identifier tokens correctly, rev. 1

Comment 3

[Benjamin Smedberg]

https://hg.mozilla.org/integration/mozilla-inbound/rev/be715fe9c916

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/be715fe9c916