xpidl parses long longValue as long long Value

RESOLVED FIXED in mozilla15

Status

()

Product:
Core
Component:
XPCOM
Status:
RESOLVED FIXED
Reported:
7 years ago
Modified:
7 years ago

People

(Reporter: dcs25, Assigned: benjamin)

Tracking

Version:
12 Branch
Target:
mozilla15
Platform:
x86
macOS
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Parse multi-word identifier tokens correctly, rev. 1
1.16 KB, patch
khuey
: review+
Details | Diff | Splinter Review
(Reporter)

Description

•
7 years ago 
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_3) AppleWebKit/536.5 (KHTML, like Gecko) Chrome/19.0.1084.41 Safari/536.5

Steps to reproduce:

Picked up work on a very old project and moved to the new python based xpidl after grabbing XULRunner 12.


Actual results:

It appears that the lexer chokes on:

attribute long longValue;

which generates:

  /* attribute long long Value; */
  NS_SCRIPTABLE NS_IMETHOD GetValue(PRInt64 *aValue) = 0;
  NS_SCRIPTABLE NS_IMETHOD SetValue(PRInt64 aValue) = 0;


Expected results:

Of course, this actually a long type named longValue, which worked fine with the old binary build.

I tried unsigned long long, expecting it to break as well, and sure enough, it did.
 (Assignee)

Comment 1

•
7 years ago 
That's bizarre!
 (Assignee)

Comment 2

•
7 years ago 
Created attachment 623182 [details] [diff] [review]
Parse multi-word identifier tokens correctly, rev. 1
Assignee: nobody → benjamin
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #623182 - Flags: review?(khuey)
 (Assignee)

Comment 3

•
7 years ago 
https://hg.mozilla.org/integration/mozilla-inbound/rev/be715fe9c916
Target Milestone: --- → mozilla15

Comment 4

•
7 years ago 
https://hg.mozilla.org/mozilla-central/rev/be715fe9c916
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.