Closed Bug 754292 Opened 12 years ago Closed 12 years ago

Make spellcheck-textarea-ref.html blur its contents so that we would test the right thing

Categories

(Core :: DOM: Editor, defect)

Product:
Core
Component:
DOM: Editor
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla15

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

Details

Attachments

(1 file)

Patch (v1)
2.28 KB, patch
roc
: review+
Details | Diff | Splinter Review 
REFTEST TEST-UNEXPECTED-PASS | http://10.250.48.210:30073/tests/layout/reftests/xul/menulist-shrinkwrap-2.xul | image comparison (==)
REFTEST TEST-UNEXPECTED-PASS | http://10.250.48.210:30073/tests/editor/reftests/spellcheck-textarea-attr.html | image comparison (!=)
REFTEST TEST-UNEXPECTED-PASS | http://10.250.48.210:30073/tests/editor/reftests/spellcheck-textarea-nofocus.html | image comparison (!=)
REFTEST TEST-UNEXPECTED-PASS | http://10.250.48.210:30073/tests/editor/reftests/spellcheck-textarea-disabled.html | image comparison (!=)
REFTEST TEST-UNEXPECTED-PASS | http://10.250.48.210:30073/tests/editor/reftests/spellcheck-textarea-attr-inherit.html | image comparison (!=)
REFTEST TEST-UNEXPECTED-PASS | http://10.250.48.210:30073/tests/editor/reftests/spellcheck-textarea-attr-dynamic.html | image comparison (!=)
REFTEST TEST-UNEXPECTED-PASS | http://10.250.48.210:30073/tests/editor/reftests/spellcheck-textarea-attr-dynamic-inherit.html | image comparison (!=)
REFTEST TEST-UNEXPECTED-PASS | http://10.250.48.210:30073/tests/editor/reftests/spellcheck-textarea-property-dynamic.html | image comparison (!=)
REFTEST TEST-UNEXPECTED-PASS | http://10.250.48.210:30073/tests/editor/reftests/spellcheck-textarea-property-dynamic-inherit.html | image comparison (!=)
REFTEST TEST-UNEXPECTED-PASS | http://10.250.48.210:30073/tests/editor/reftests/spellcheck-textarea-attr-dynamic-override.html | image comparison (!=)
REFTEST TEST-UNEXPECTED-PASS | http://10.250.48.210:30073/tests/editor/reftests/spellcheck-textarea-attr-dynamic-override-inherit.html | image comparison (!=)
REFTEST TEST-UNEXPECTED-PASS | http://10.250.48.210:30073/tests/editor/reftests/spellcheck-textarea-property-dynamic-override.html | image comparison (!=)
REFTEST TEST-UNEXPECTED-PASS | http://10.250.48.210:30073/tests/editor/reftests/spellcheck-textarea-property-dynamic-override-inherit.html | image comparison (!=)
Actually, this happens because spellcheck-textarea-ref.html focuses the textarea to trigger a spell check, but does not blur it, and the textarea looking different when focused is the reason these tests pass.  We should just fix spellcheck-textarea-ref.html to not do that!
Summary: Mark some spellchecking reftests as passing on Android → Make spellcheck-textarea-ref.html blur its contents so that we would test the right thing
Attached patch Patch (v1) — — Splinter Review 
Assignee: nobody → ehsan
Status: NEW → ASSIGNED

        Attachment #623155 -
        Flags: review?(roc)

    
    

    
  
https://hg.mozilla.org/integration/mozilla-inbound/rev/af802c58e1cf
Flags: in-testsuite+
Target Milestone: --- → mozilla15

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/af802c58e1cf
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: