The default bug view has changed. See this FAQ.

Make spellcheck-textarea-ref.html blur its contents so that we would test the right thing

RESOLVED FIXED in mozilla15

Status

()

Core
Editor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

Trunk
mozilla15
x86_64
Linux
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
REFTEST TEST-UNEXPECTED-PASS | http://10.250.48.210:30073/tests/layout/reftests/xul/menulist-shrinkwrap-2.xul | image comparison (==)
REFTEST TEST-UNEXPECTED-PASS | http://10.250.48.210:30073/tests/editor/reftests/spellcheck-textarea-attr.html | image comparison (!=)
REFTEST TEST-UNEXPECTED-PASS | http://10.250.48.210:30073/tests/editor/reftests/spellcheck-textarea-nofocus.html | image comparison (!=)
REFTEST TEST-UNEXPECTED-PASS | http://10.250.48.210:30073/tests/editor/reftests/spellcheck-textarea-disabled.html | image comparison (!=)
REFTEST TEST-UNEXPECTED-PASS | http://10.250.48.210:30073/tests/editor/reftests/spellcheck-textarea-attr-inherit.html | image comparison (!=)
REFTEST TEST-UNEXPECTED-PASS | http://10.250.48.210:30073/tests/editor/reftests/spellcheck-textarea-attr-dynamic.html | image comparison (!=)
REFTEST TEST-UNEXPECTED-PASS | http://10.250.48.210:30073/tests/editor/reftests/spellcheck-textarea-attr-dynamic-inherit.html | image comparison (!=)
REFTEST TEST-UNEXPECTED-PASS | http://10.250.48.210:30073/tests/editor/reftests/spellcheck-textarea-property-dynamic.html | image comparison (!=)
REFTEST TEST-UNEXPECTED-PASS | http://10.250.48.210:30073/tests/editor/reftests/spellcheck-textarea-property-dynamic-inherit.html | image comparison (!=)
REFTEST TEST-UNEXPECTED-PASS | http://10.250.48.210:30073/tests/editor/reftests/spellcheck-textarea-attr-dynamic-override.html | image comparison (!=)
REFTEST TEST-UNEXPECTED-PASS | http://10.250.48.210:30073/tests/editor/reftests/spellcheck-textarea-attr-dynamic-override-inherit.html | image comparison (!=)
REFTEST TEST-UNEXPECTED-PASS | http://10.250.48.210:30073/tests/editor/reftests/spellcheck-textarea-property-dynamic-override.html | image comparison (!=)
REFTEST TEST-UNEXPECTED-PASS | http://10.250.48.210:30073/tests/editor/reftests/spellcheck-textarea-property-dynamic-override-inherit.html | image comparison (!=)
(Assignee)

Comment 1

5 years ago
Actually, this happens because spellcheck-textarea-ref.html focuses the textarea to trigger a spell check, but does not blur it, and the textarea looking different when focused is the reason these tests pass.  We should just fix spellcheck-textarea-ref.html to not do that!
Summary: Mark some spellchecking reftests as passing on Android → Make spellcheck-textarea-ref.html blur its contents so that we would test the right thing
(Assignee)

Comment 2

5 years ago
Created attachment 623155 [details] [diff] [review]
Patch (v1)
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #623155 - Flags: review?(roc)
Attachment #623155 - Flags: review?(roc) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/af802c58e1cf
Flags: in-testsuite+
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/af802c58e1cf
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.