754329 - Crash with cairo mutexes enabled

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Marco Castelluccio [:marco]]

Attachment: Stack trace

Firefox crashes if built with cairo mutexes enabled.
Stack trace attached.

Comment 1

[Benoit Girard (:BenWa)]

marco: BenWa, I see cairo_debug_reset_static_data is being called before destroying a cairo surface

marco: maybe this is the problem with the crash

BenWa: marco: Is it mScreenReferenceSurface that's causing the crash?

BenWa: Your theory is good, you should try 2 things: 1) comment out that reset static data call, 2) set 'mScreenReferenceSurface = nsnull' before that function is called (forcing refcount to delete it)

BenWa: Calling cairo_debug_reset_static_data when we still have cairo data allocated is bad so that explains the crash. Its a bit curious that it's windows only however

Comment 2

[Benoit Girard (:BenWa)]

This crash doesn't happen on trunk, it only happens with a patch from bug 705691.

Comment 3

[Marco Castelluccio [:marco]]

Attachment: Patch

I've written a really simple patch to shutdown imgLib after gfxPlatform. Here is the try run: https://tbpl.mozilla.org/?tree=Try&rev=fd8ef74457e7

Comment 4

[Benoit Girard (:BenWa)]

Comment on attachment 623398 [details] [diff] [review]
Patch

LGTM. We should run a full set of test before landing it.

Comment 5

[Benoit Girard (:BenWa)]

Pushed to try:
https://tbpl.mozilla.org/?tree=Try&rev=04ccf2579684

Sorry Macro I was distracted this Friday/weekend, lets get this back on track and landed.

Comment 6

[Marco Castelluccio [:marco]]

I think we can land this: https://tbpl.mozilla.org/?tree=Try&rev=122b327195b2

Comment 7

[Benoit Girard (:BenWa)]

Feel free to tag check-in?bgirard next time to add it to my queue.

Comment 8

[Benoit Girard (:BenWa)]

Comment on attachment 623398 [details] [diff] [review]
Patch

https://hg.mozilla.org/integration/mozilla-inbound/rev/5aa6fad6aa88

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5aa6fad6aa88