Last Comment Bug 754329 - Crash with cairo mutexes enabled
: Crash with cairo mutexes enabled
: crash
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: Other Branch
: x86_64 Windows 7
-- normal (vote)
: mozilla15
Assigned To: Marco Castelluccio [:marco]
: Milan Sreckovic [:milan]
Depends on:
Blocks: 705691
  Show dependency treegraph
Reported: 2012-05-11 09:22 PDT by Marco Castelluccio [:marco]
Modified: 2012-05-24 10:55 PDT (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Stack trace (2.16 KB, text/plain)
2012-05-11 09:22 PDT, Marco Castelluccio [:marco]
no flags Details
Patch (2.24 KB, patch)
2012-05-12 01:44 PDT, Marco Castelluccio [:marco]
joe: review+
b56girard: feedback+
b56girard: checkin+
Details | Diff | Splinter Review

Description User image Marco Castelluccio [:marco] 2012-05-11 09:22:05 PDT
Created attachment 623181 [details]
Stack trace

Firefox crashes if built with cairo mutexes enabled.
Stack trace attached.
Comment 1 User image Benoit Girard (:BenWa) 2012-05-11 10:04:47 PDT
marco: BenWa, I see cairo_debug_reset_static_data is being called before destroying a cairo surface

marco: maybe this is the problem with the crash

BenWa: marco: Is it mScreenReferenceSurface that's causing the crash?

BenWa: Your theory is good, you should try 2 things: 1) comment out that reset static data call, 2) set 'mScreenReferenceSurface = nsnull' before that function is called (forcing refcount to delete it)

BenWa: Calling cairo_debug_reset_static_data when we still have cairo data allocated is bad so that explains the crash. Its a bit curious that it's windows only however
Comment 2 User image Benoit Girard (:BenWa) 2012-05-11 10:50:10 PDT
This crash doesn't happen on trunk, it only happens with a patch from bug 705691.
Comment 3 User image Marco Castelluccio [:marco] 2012-05-12 01:44:40 PDT
Created attachment 623398 [details] [diff] [review]

I've written a really simple patch to shutdown imgLib after gfxPlatform. Here is the try run:
Comment 4 User image Benoit Girard (:BenWa) 2012-05-12 07:37:57 PDT
Comment on attachment 623398 [details] [diff] [review]

LGTM. We should run a full set of test before landing it.
Comment 5 User image Benoit Girard (:BenWa) 2012-05-14 10:16:54 PDT
Pushed to try:

Sorry Macro I was distracted this Friday/weekend, lets get this back on track and landed.
Comment 6 User image Marco Castelluccio [:marco] 2012-05-23 03:35:38 PDT
I think we can land this:
Comment 7 User image Benoit Girard (:BenWa) 2012-05-23 08:24:56 PDT
Feel free to tag check-in?bgirard next time to add it to my queue.
Comment 9 User image Ed Morley [:emorley] 2012-05-24 10:55:14 PDT

Note You need to log in before you can comment on or make changes to this bug.