Let Thunderbird have access to ContactService.jsm and ContactDB.jsm.

RESOLVED FIXED in mozilla15

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mconley, Assigned: mconley)

Tracking

unspecified
mozilla15
x86
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 623278 [details] [diff] [review]
Patch v1

ContactService.jsm and ContactDB.jsm are the fallback storage mechanism for the Contacts API, and are currently only available in b2g builds.

The Thunderbird team has started to make moves to use the Contacts API for storage / retrieval of contacts for a new address book.  One of those moves is to start working on desktop support for the Contacts API.  As part of this effort, we'll want access to the fallback storage mechanism.

The attached patch alters the Makefile for dom/contacts to package ContactService.jsm and ContactDB.jsm for both b2g and mail.
(Assignee)

Comment 1

5 years ago
Comment on attachment 623278 [details] [diff] [review]
Patch v1

r?'ing fabrice because he originally r+'d the patch in bug 731855.
Attachment #623278 - Flags: review?(fabrice)
(Assignee)

Comment 2

5 years ago
So that filter is my way of doing logical OR for Makefiles... let me know if there's another preferred method.
(Assignee)

Updated

5 years ago
Blocks: 754390
Comment on attachment 623278 [details] [diff] [review]
Patch v1

Review of attachment 623278 [details] [diff] [review]:
-----------------------------------------------------------------

I don't know of any other method either.
Attachment #623278 - Flags: review?(fabrice) → review+
(Assignee)

Comment 4

5 years ago
Thanks for the fast review, Fabrice.

mozilla-inbound:  https://hg.mozilla.org/integration/mozilla-inbound/rev/de6d19899b89
https://hg.mozilla.org/mozilla-central/rev/de6d19899b89
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15

Comment 6

5 years ago
Does this also include SeaMonkey? Or do we need an extra patch in /suite/?
(Assignee)

Comment 7

5 years ago
(In reply to Philip Chee from comment #6)
> Does this also include SeaMonkey? Or do we need an extra patch in /suite/?

This patch only took care of Thunderbird, I'm afraid. If suite needs access to ContactService.jsm and ContactDB.jsm, an extra patch will be required here.
You need to log in before you can comment on or make changes to this bug.