Closed
Bug 754457
Opened 12 years ago
Closed 12 years ago
Disallow ErrorResult copy constructor
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
Attachments
(1 file)
|
785 bytes,
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
I accidentally wrote a function that took an ErrorResult by value, not by reference. This is busted, of course, because attempts to Throw() on the thing in the function won't be seen by the caller. Patch coming up to disable the copy constructor for ErrorResult so this can't happen.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #623315 -
Flags: review?(peterv)
|
|
Assignee | |
Updated•12 years ago
|
Whiteboard: [need review]
|
||
Updated•12 years ago
|
Attachment #623315 -
Flags: review?(peterv) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/095eef67ec7b
Flags: in-testsuite-
Whiteboard: [need review]
Target Milestone: --- → mozilla15
|
|
Assignee | |
Updated•12 years ago
|
Flags: in-testsuite- → in-testsuite?
|
||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/095eef67ec7b
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•