The default bug view has changed. See this FAQ.

Disallow ErrorResult copy constructor

RESOLVED FIXED in mozilla15

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

unspecified
mozilla15
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

I accidentally wrote a function that took an ErrorResult by value, not by reference.  This is busted, of course, because attempts to Throw() on the thing in the function won't be seen by the caller.

Patch coming up to disable the copy constructor for ErrorResult so this can't happen.
Created attachment 623315 [details] [diff] [review]
Disallow copy-construction of ErrorResult, so it can only be passed by reference, not by value.
Attachment #623315 - Flags: review?(peterv)
Whiteboard: [need review]
Attachment #623315 - Flags: review?(peterv) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/095eef67ec7b
Flags: in-testsuite-
Whiteboard: [need review]
Target Milestone: --- → mozilla15
Flags: in-testsuite- → in-testsuite?
https://hg.mozilla.org/mozilla-central/rev/095eef67ec7b
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.