Closed
Bug 754464
Opened 13 years ago
Closed 13 years ago
Pressing "add comment" with a selected build active should not un-select it
Categories
(Tree Management Graveyard :: TBPL, defect)
Tree Management Graveyard
TBPL
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mbrubeck, Assigned: mbrubeck)
References
Details
Attachments
(1 file, 1 obsolete file)
|
2.29 KB,
patch
|
philor
:
review+
|
Details | Diff | Splinter Review |
Just a minor little pet peeve...
Steps to reproduce:
1. Select some builds (using spacebar or control-click).
2. With the last selected build still active, add a comment (type "C" or click "add a comment").
Expected results: Comment is added to all builds selected in step 1.
Actual results: The active build gets un-selected, so the comment is added only to the other builds.
With this patch, pressing "add a comment" will select the active build if needed, but it will never un-select it.
Attachment #623321 -
Flags: review?(philringnalda)
|
Assignee | |
Comment 1•13 years ago
|
||
I accidentally removed one line too many.
Also, no one is using the return value from _toggleSelectedBuild, so let's get rid of it and simplify the code.
Assignee: nobody → mbrubeck
Attachment #623321 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #623321 -
Flags: review?(philringnalda)
Attachment #623323 -
Flags: review?(philringnalda)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 623323 [details] [diff] [review]
patch v2
lgtm, though it'll be years before my workaround habits die :)
Attachment #623323 -
Flags: review?(philringnalda) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Product: Webtools → Tree Management
|
|
||
Updated•10 years ago
|
Product: Tree Management → Tree Management Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•