Closed Bug 754503 Opened 9 years ago Closed 9 years ago

Some embedded Flash on abcnews.com will not load (plugin object area is blank)

Categories

(Core :: JavaScript Engine, defect)

14 Branch
defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla15
Tracking Status
firefox14 --- verified
firefox15 + verified

People

(Reporter: fehe, Assigned: luke)

References

()

Details

(Keywords: regression, Whiteboard: [js:p1:fx15])

Attachments

(3 files)

Some embedded Flash on abcnews.com will not load (plugin object area is blank)

STR:
Visit the following URL: http://abcnews.go.com/Nightline/mythbusters-kardashian-fact-versus-fairy-tale/story?id=10729219#.T62lo32_4SH

The regression window is:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=b1421c3cd5c8&tochange=1664d00a1d24

Caused by either bug 740446 or bug 740259.  Suspect bug 740259.
Yep, definitely bug 740259.  I'll look into it.
Assignee: general → luke
Attached patch fixSplinter Review
This is funny.  I bisected the problem to a line of JS in flashembed.js:
  var i=document.all
where "i" is an aliased variable.  The bug is that JSOP_SETLOCAL is JOF_DETECTING and JSOP_SETALIASEDVAR is not.

Finally, FF users can find out the answer to that burning question:
  Fact vs. Fairy Tale: Does Kim Kardashian Have Butt Implants?
Attachment #623736 - Flags: review?(bhackett1024)
Attachment #623736 - Flags: review?(bhackett1024) → review+
Comment on attachment 623736 [details] [diff] [review]
fix

[Approval Request Comment]
Regression caused by (bug #): 740259
User impact if declined: broken web pages (such as comment 0)
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): very low
Attachment #623736 - Flags: approval-mozilla-aurora?
Whiteboard: [js:p1:fx15]
https://hg.mozilla.org/mozilla-central/rev/984073312d57
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment on attachment 623736 [details] [diff] [review]
fix

[Triage Comment]
Website breakage, regression in 14, low risk. Approved for Aurora 14.
Attachment #623736 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
No longer blocks: 740259
Version: Trunk → 14 Branch
Blocks: 740259
Verified fixed on FF 14b7 on Win 7, Ubuntu 12.04 and Mac OS X 10.6.
OS: Windows XP → All
Hardware: x86 → All
Whiteboard: [js:p1:fx15] → [js:p1:fx15][qa+:paul.silaghi]
Flash content is loaded ok. Verified fixed on FF 15b3 on Win 7, Ubuntu 12.04 and Mac OS X 10.6.
Status: RESOLVED → VERIFIED
Whiteboard: [js:p1:fx15][qa+:paul.silaghi] → [js:p1:fx15]
Comment on attachment 663318 [details]
Test case wmv video failing

Verified error on Firefox 15 on windows Xp

Object area is blank on loading the page, it takes more than 30 seconds once the video is downloaded to appear.

Is not a matter of the browser waiting the video to download and then showing it after the download is finished
because if you use a video stored on your filesystem (without a server) it takes more time to appear and sometimes 
it doesn't even appear and only selecting the object in firebug on the HTML tab forces the video content to load.

Verified the error with the following three ways to include a WMV video (only one at a time) :
 
           <embed name="video" style="border:1px solid blue" type="application/x-mplayer2" src ="http://res1.windows.microsoft.com/resbox/en/Windows%207/Main/c4e45c98-505e-471d-80c3-a383dea3d647_7.wmv" width="800" height="600" showcontrols="1"></embed>
		
			<object type="video/x-ms-wmv" style="border:1px solid blue" data="http://res1.windows.microsoft.com/resbox/en/Windows%207/Main/c4e45c98-505e-471d-80c3-a383dea3d647_7.wmv" width="800" height="600">
              <param name="src" value="http://res1.windows.microsoft.com/resbox/en/Windows%207/Main/c4e45c98-505e-471d-80c3-a383dea3d647_7.wmv" />
              <param name="controller" value="true" />
              <param name="autostart" value="true" />
            </object>
		
            <object type="application/x-mplayer2" style="border:1px solid blue" width="800" height="600" data="http://res1.windows.microsoft.com/resbox/en/Windows%207/Main/c4e45c98-505e-471d-80c3-a383dea3d647_7.wmv">
                  <param name="pluginurl" value="http://www.microsoft.com/Windows/MediaPlayer/" />
                  <param name="controller" value="true" />
            </object>
A workaround has been found duplicating the object (with very small dimensions to not interfere on the display), when more than one object is present on the page the first video loads OK and appears instantly on the page and only the last video included takes more time to load.
volatilevol, this bug is fixed and verified. If you think you have discovered a new issue, please file a new bug.
You need to log in before you can comment on or make changes to this bug.