configure should test for SQLITE_MAX_DEFAULT_PAGE_SIZE and SQLITE_MAX_SCHEMA_RETRY with --enable-system-sqlite

NEW
Unassigned

Status

Firefox Build System
General
6 years ago
3 months ago

People

(Reporter: glandium, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

6 years ago
Sadly, AFAICT, there is no API to get the value of compile options, so it's probably not possible for SQLITE_MAX_SCHEMA_RETRY, but for SQLITE_MAX_DEFAULT_PAGE_SIZE, we can probably do a run test checking if setting a page size of 32k yields a 32k page size (since the default in sqlite is 8k). I don't think testing for SQLITE_DEFAULT_PAGE_SIZE is important.

I recently noticed that the system sqlite I'm using doesn't have these two compile options, and it would have been more helpful if configure would have just thrown an error at my face.

Comment 1

4 years ago
Slightly modified from Firefox's configure.in test for system-sqlite's SECURE_DELETE option:

#include "sqlite3.h"
int main(int argc, char **argv){
    return sqlite3_compileoption_used("SQLITE_SECURE_DELETE");

Adjust as necessary.

Updated

3 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.