Fix unused-result warnings in Windows-specific code

RESOLVED FIXED in mozilla15

Status

()

Core
Widget: Win32
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Jacek Caban, Assigned: Jacek Caban)

Tracking

(Blocks: 1 bug)

Trunk
mozilla15
x86
Windows 7
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 623429 [details] [diff] [review]
fix v1.0

With patch from bug 736501, new errors were found by mingw compilation that were not found by MSVC (which doesn't support unused-warn). The attached patch fixes them.

Since I'm changing widget/windows code, I've also included trivial change that properly includes windows.h in TestAppShellSteadyState.cpp (to fix cross compiling on case-sensitive OSes).
Attachment #623429 - Flags: review?(benjamin)
Comment on attachment 623429 [details] [diff] [review]
fix v1.0

>diff --git a/dom/plugins/ipc/PluginInstanceParent.cpp b/dom/plugins/ipc/PluginInstanceParent.cpp

>-                CallPaint(npremoteevent, &handled);
>+                if(!CallPaint(npremoteevent, &handled)) {
>+                    handled = false;
>+                }

nit, please un-snuggle the "if("
Attachment #623429 - Flags: review?(benjamin) → review+
(Assignee)

Comment 2

5 years ago
Thanks for the review. Pushed to m-i:

https://hg.mozilla.org/integration/mozilla-inbound/rev/255b7fd26002
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/255b7fd26002
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.