Closed
Bug 754582
Opened 13 years ago
Closed 13 years ago
Fix unused-result warnings in Windows-specific code
Categories
(Core :: Widget: Win32, defect)
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: jacek, Assigned: jacek)
References
Details
Attachments
(1 file)
|
7.28 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
With patch from bug 736501, new errors were found by mingw compilation that were not found by MSVC (which doesn't support unused-warn). The attached patch fixes them.
Since I'm changing widget/windows code, I've also included trivial change that properly includes windows.h in TestAppShellSteadyState.cpp (to fix cross compiling on case-sensitive OSes).
Attachment #623429 -
Flags: review?(benjamin)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 623429 [details] [diff] [review]
fix v1.0
>diff --git a/dom/plugins/ipc/PluginInstanceParent.cpp b/dom/plugins/ipc/PluginInstanceParent.cpp
>- CallPaint(npremoteevent, &handled);
>+ if(!CallPaint(npremoteevent, &handled)) {
>+ handled = false;
>+ }
nit, please un-snuggle the "if("
Attachment #623429 -
Flags: review?(benjamin) → review+
|
Assignee | |
Comment 2•13 years ago
|
||
Thanks for the review. Pushed to m-i:
https://hg.mozilla.org/integration/mozilla-inbound/rev/255b7fd26002
Target Milestone: --- → mozilla15
|
||
Comment 3•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•