Last Comment Bug 754582 - Fix unused-result warnings in Windows-specific code
: Fix unused-result warnings in Windows-specific code
Product: Core
Classification: Components
Component: Widget: Win32 (show other bugs)
: Trunk
: x86 Windows 7
-- normal (vote)
: mozilla15
Assigned To: Jacek Caban
: Jim Mathies [:jimm]
Depends on:
Blocks: 736501
  Show dependency treegraph
Reported: 2012-05-12 08:04 PDT by Jacek Caban
Modified: 2012-05-16 19:32 PDT (History)
2 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

fix v1.0 (7.28 KB, patch)
2012-05-12 08:04 PDT, Jacek Caban
benjamin: review+
Details | Diff | Splinter Review

Description User image Jacek Caban 2012-05-12 08:04:39 PDT
Created attachment 623429 [details] [diff] [review]
fix v1.0

With patch from bug 736501, new errors were found by mingw compilation that were not found by MSVC (which doesn't support unused-warn). The attached patch fixes them.

Since I'm changing widget/windows code, I've also included trivial change that properly includes windows.h in TestAppShellSteadyState.cpp (to fix cross compiling on case-sensitive OSes).
Comment 1 User image Benjamin Smedberg [:bsmedberg] 2012-05-15 12:05:58 PDT
Comment on attachment 623429 [details] [diff] [review]
fix v1.0

>diff --git a/dom/plugins/ipc/PluginInstanceParent.cpp b/dom/plugins/ipc/PluginInstanceParent.cpp

>-                CallPaint(npremoteevent, &handled);
>+                if(!CallPaint(npremoteevent, &handled)) {
>+                    handled = false;
>+                }

nit, please un-snuggle the "if("
Comment 2 User image Jacek Caban 2012-05-16 01:50:36 PDT
Thanks for the review. Pushed to m-i:
Comment 3 User image Ryan VanderMeulen [:RyanVM] 2012-05-16 19:32:19 PDT

Note You need to log in before you can comment on or make changes to this bug.