754637 - double tab to zoom guesses wrong

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Jeff Griffiths (:canuckistani) (:⚡︎)]

Attachment: screenshot

In some cases, double-tap to zoom guesses wrong, as seen on http://www.mvilla.it/epistle.html

to repro:

* load http://www.mvilla.it/epistle.html
* double tab to zoom in, left edge of paragraph text is no longer visible, the viewport seems to zoom in to the left edge of the unordered list.

Comment 1

[Matt Brubeck (:mbrubeck)]

Attachment: patch

This patch causes Fennec not to zoom in on <li> elements.  It will zoom to the containing element instead.  This fixes the page from comment 0.

The patch also excludes <blockquote> elements, for similar reasons.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 623501 [details] [diff] [review]
patch

ok, this makes sense.

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/658391fe57eb
https://hg.mozilla.org/mozilla-central/rev/658391fe57eb

Comment 4

[Cristian Nicolae (:xti)]

Double tap to zoom works correctly on the webpage from comment #0. 

Closing bug as verified fixed on:

Firefox 19.0a1 (2012-10-17)
Device: Galaxy Note
OS: Android 4.0.4