754668 - When resetting a required input, it becomes invalid

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Théo Chevalier]

See the jsfiddle attached.
STR: 
1) Fill in the fields with a name, an email address, a message
2) Click on "Reset"

A red border appears around the inputs, whereas the textarea behavior is good: no red border.

Expected: All the fields should be cleared, and no red border should appear.

Works on all the others browsers.

Comment 1

[Boris Zbarsky [:bzbarsky]]

And clicking "Reset" again makes the red outline disappear.  That's kinda weird.

Comment 2

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

nsTextEditorState was setting mValueChanged to true when resetting the value to the default value. I could have written a patch setting mValueChanged to false after resetting the value but I think that would have just hidden the issue given that there are other situations where we don't want to update mValueChanged.

Comment 3

[(no longer active)]

Comment on attachment 624068 [details] [diff] [review]
Patch v1

Review of attachment 624068 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/32b0dd97f69b