Created attachment 623621 [details] [diff] [review]
That's because it tries to use MSVC assembly in float_cast.h. The attached patch defines HAVE_LRINTF for mingw, so that GCC code path is taken.
Comment on attachment 623621 [details] [diff] [review]
Looks good to me.
Please update the patch with a more verbose log message including the bug number and more details of why the change is being made. For example:
Bug 754797 - libopus fails to compile on mingw - r=rillian
Define HAVE_LRINTF when compiling with GCC on Windows to avoid
the MSVC assembly implementation in libopus/celt/float_cast.h.
Ralph, sorry that Autoland doesn't strip off whitespace right now - i have filed bug 755054 to get that change in when there's a spare minute.
Branch: mozilla-central => try
Try run started, revision b0b494f311b9. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=b0b494f311b9
Thanks for the review. Pushed with commit comment to m-i:
(In reply to Lukas Blakk [:lsblakk] from comment #2)
> Ralph, sorry that Autoland doesn't strip off whitespace right now
Aha. Thanks Lukas!