The default bug view has changed. See this FAQ.

libopus fails to compile on mingw

RESOLVED FIXED in mozilla15

Status

()

Core
Audio/Video
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Jacek Caban, Assigned: Jacek Caban)

Tracking

Trunk
mozilla15
x86
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 623621 [details] [diff] [review]
fix v1.0

That's because it tries to use MSVC assembly in float_cast.h. The attached patch defines HAVE_LRINTF for mingw, so that GCC code path is taken.
Attachment #623621 - Flags: review?(giles)
Whiteboard: [autoland-try: try: -b do -n -p win32,win64 -u none -t none]
Comment on attachment 623621 [details] [diff] [review]
fix v1.0

Looks good to me.

Please update the patch with a more verbose log message including the bug number and more details of why the change is being made. For example:

Bug 754797 - libopus fails to compile on mingw - r=rillian

Define HAVE_LRINTF when compiling with GCC on Windows to avoid
the MSVC assembly implementation in libopus/celt/float_cast.h.
Attachment #623621 - Flags: review?(giles) → review+
Whiteboard: [autoland-try: try: -b do -n -p win32,win64 -u none -t none] → [autoland-try: -b do -n -p win32,win64 -u none -t none]
Whiteboard: [autoland-try: -b do -n -p win32,win64 -u none -t none] → [autoland-try:-b do -n -p win32,win64 -u none -t none]

Updated

5 years ago
Whiteboard: [autoland-try:-b do -n -p win32,win64 -u none -t none] → [autoland-in-queue]
Ralph, sorry that Autoland doesn't strip off whitespace right now - i have filed bug 755054 to get that change in when there's a spare minute.

Comment 3

5 years ago
Autoland Patchset:
	Patches: 623621
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=b0b494f311b9
Try run started, revision b0b494f311b9. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=b0b494f311b9
(Assignee)

Comment 4

5 years ago
Thanks for the review. Pushed with commit comment to m-i:

https://hg.mozilla.org/integration/mozilla-inbound/rev/975f2617b639
Target Milestone: --- → mozilla15
(In reply to Lukas Blakk [:lsblakk] from comment #2)
> Ralph, sorry that Autoland doesn't strip off whitespace right now 

Aha. Thanks Lukas!
https://hg.mozilla.org/mozilla-central/rev/975f2617b639
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [autoland-in-queue]
You need to log in before you can comment on or make changes to this bug.