Closed
Bug 754797
Opened 13 years ago
Closed 13 years ago
libopus fails to compile on mingw
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: jacek, Assigned: jacek)
Details
Attachments
(1 file)
|
604 bytes,
patch
|
rillian
:
review+
|
Details | Diff | Splinter Review |
That's because it tries to use MSVC assembly in float_cast.h. The attached patch defines HAVE_LRINTF for mingw, so that GCC code path is taken.
Attachment #623621 -
Flags: review?(giles)
|
||
Updated•13 years ago
|
Whiteboard: [autoland-try: try: -b do -n -p win32,win64 -u none -t none]
|
|
||
Comment 1•13 years ago
|
||
Comment on attachment 623621 [details] [diff] [review]
fix v1.0
Looks good to me.
Please update the patch with a more verbose log message including the bug number and more details of why the change is being made. For example:
Bug 754797 - libopus fails to compile on mingw - r=rillian
Define HAVE_LRINTF when compiling with GCC on Windows to avoid
the MSVC assembly implementation in libopus/celt/float_cast.h.
Attachment #623621 -
Flags: review?(giles) → review+
|
|
||
Updated•13 years ago
|
Whiteboard: [autoland-try: try: -b do -n -p win32,win64 -u none -t none] → [autoland-try: -b do -n -p win32,win64 -u none -t none]
|
||
Updated•13 years ago
|
Whiteboard: [autoland-try: -b do -n -p win32,win64 -u none -t none] → [autoland-try:-b do -n -p win32,win64 -u none -t none]
|
||
Updated•13 years ago
|
Whiteboard: [autoland-try:-b do -n -p win32,win64 -u none -t none] → [autoland-in-queue]
|
|
||
Comment 2•13 years ago
|
||
Ralph, sorry that Autoland doesn't strip off whitespace right now - i have filed bug 755054 to get that change in when there's a spare minute.
|
|
||
Comment 3•13 years ago
|
||
Autoland Patchset:
Patches: 623621
Branch: mozilla-central => try
Destination: http://hg.mozilla.org/try/pushloghtml?changeset=b0b494f311b9
Try run started, revision b0b494f311b9. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=b0b494f311b9
|
Assignee | |
Comment 4•13 years ago
|
||
Thanks for the review. Pushed with commit comment to m-i:
https://hg.mozilla.org/integration/mozilla-inbound/rev/975f2617b639
Target Milestone: --- → mozilla15
|
|
||
Comment 5•13 years ago
|
||
(In reply to Lukas Blakk [:lsblakk] from comment #2)
> Ralph, sorry that Autoland doesn't strip off whitespace right now
Aha. Thanks Lukas!
|
|
||
Comment 6•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [autoland-in-queue]
You need to log in
before you can comment on or make changes to this bug.
Description
•