75482 - RFE: deactivate groups and prevent bugs being added to them

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement, P3)

Description

[Myk Melez [:myk] [@mykmelez]]

There are situations in which a Bugzilla installation may want to "close out" a
bug group over time rather than immediately by making it possible for users to
continue working on bugs in the group without giving them the ability to extend
the life of the group by adding new bugs to it.

Since access to the bugs should remain restricted, releasing the bugs back into
the wild and deleting the group is not an option.

One solution is to add a column to the "groups" table that records whether or
not a group is active.  An active group can be used in the same way groups are
used in Bugzilla today.  An inactive group, on the other hand, has certain
restrictions on how it can be used that are intended to discourage further use
of the group.  In particular, it is not possible to add bugs to an inactive
group.  There may also be other restrictions on that group.

I have created a patch that adds UI to the "Edit Groups" screen for
de/activating groups and hides the UI in the "Edit Bug" screen for adding a bug
to an inactive group.  The following SQL command adds the appropriate column to
the "groups" table, and I will attach a patch with my changes to bug_form.pl and
editgroups.pl:

ALTER TABLE groups ADD COLUMN isactive TINYINT NOT NULL DEFAULT 1;

-myk

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Attachment: diff to bug_form.pl and editgroups.pl

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Attachment: diff to checksetup.pl to add "isactive" field to "groups" table

Comment 3

[Myk Melez [:myk] [@mykmelez]]

cc:ing people who should know about this bug

Comment 4

[Dave Miller [:justdave]]

this is a Security Thing (tm)
-> 2.14

Comment 5

[Jacob Steenhagen]

Attachment: Patch to checksetup.pl

Comment 6

[Jacob Steenhagen]

Attachment: Forgot I was testing Gerv's duplicates patch

Comment 7

[Dave Miller [:justdave]]

I should point out that you'll need a patch to post_bug.cgi to stop people from 
filing new bugs into said groups.

Comment 8

[Myk Melez [:myk] [@mykmelez]]

I am about to attach an updated patch that includes the following changes:

1. incorporates Jake's patch for checksetup.pl;
2. patches enter_bug.cgi so it doesn't display inactive groups in the "enter new
bug" form;
3. patches post_bug.cgi to throw an error if a new bug is added as a member of
an inactive group; (This should never happen unless there is a bug in Bugzilla
or the user hacks the "enter new bug" form to try to sneak the bug into the group.)
4. adds a function "GroupIsActive" to globals.pl which returns whether or not a
group is active; (This is useful for the post_bug.cgi patch.)
5. modifies my previous patch to form_bug.cgi so the UI for inactive groups does
get displayed if the bug is a member of the group. (My previous patch hid the UI
for inactive groups for all bugs, but if a bug is a member of a group that gets
deactivated, it should still be possible to remove the bug from the group.  In
fact, it should be encouraged.)

Comment 9

[Myk Melez [:myk] [@mykmelez]]

Attachment: updates for edit bug form and code for handling new bug form

Comment 10

[Dave Miller [:justdave]]

Can we put this on landfill?

Comment 11

[Myk Melez [:myk] [@mykmelez]]

Attachment: all the most current patches bundled together

Comment 12

[Myk Melez [:myk] [@mykmelez]]

Attachment: latest patch--doesn't have 64-bit perl integer problems

Comment 13

[Dave Miller [:justdave]]

Based on visual inspection of the patch, and on testing the heck out of it on 
landfill, looks like it works as advertised.

r= justdave

Checked in.

Comment 14

[Dave Miller [:justdave]]

Moving to Bugzilla product