754968 – Make BindingUtils.h not require private xpconnect headers

Last Comment Bug 754968 - Make BindingUtils.h not require private xpconnect headers


Summary:	Make BindingUtils.h not require private xpconnect headers

Status:	RESOLVED FIXED
Whiteboard:
Keywords:

Product:	Core
Classification:	Components
Component:	XPConnect (show other bugs)
Version:	Trunk
Platform:	All All

Importance:	-- normal (vote)
Target Milestone:	mozilla15
Assigned To:	:Ms2ger (⌚ UTC+1/+2)
QA Contact:
Triage Owner:
Mentors:

URL:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:

2012-05-14 12:29 PDT by :Ms2ger (⌚ UTC+1/+2)

Modified:

2012-05-18 06:32 PDT (History)

CC List:

2 users (show)

See Also:

Crash Signature:

(edit)

QA Whiteboard:

Iteration:

---

Points:

---

Has Regression Range:

---

Has STR:

---

Tracking Flags:

Attachments
Part a: Export xpcObjectHelper (8.39 KB, patch) 2012-05-14 12:29 PDT, :Ms2ger (⌚ UTC+1/+2)	bobbyholley: review+	Details \| Diff \| Splinter Review
Part b: Export qsObjectHelper (7.32 KB, patch) 2012-05-14 12:34 PDT, :Ms2ger (⌚ UTC+1/+2)	bobbyholley: review+	Details \| Diff \| Splinter Review
Part c: Other changes (13.96 KB, patch) 2012-05-14 12:36 PDT, :Ms2ger (⌚ UTC+1/+2)	bobbyholley: review+	Details \| Diff \| Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Description

:Ms2ger (⌚ UTC+1/+2) 2012-05-14 12:29:57 PDT

Created attachment 623766 [details] [diff] [review]
Part a: Export xpcObjectHelper

So we don't need to add xpconnect to LOCAL_INCLUDES all over.

Comment 1

:Ms2ger (⌚ UTC+1/+2) 2012-05-14 12:34:58 PDT

Created attachment 623771 [details] [diff] [review]
Part b: Export qsObjectHelper

Comment 2

:Ms2ger (⌚ UTC+1/+2) 2012-05-14 12:36:28 PDT

Created attachment 623772 [details] [diff] [review]
Part c: Other changes

Comment 3

:Ms2ger (⌚ UTC+1/+2) 2012-05-18 02:55:31 PDT

https://hg.mozilla.org/mozilla-central/rev/1c653b3c9bd8
https://hg.mozilla.org/mozilla-central/rev/3571e646fb3c
https://hg.mozilla.org/mozilla-central/rev/5babc7bc7e33

bz, you'll be able to remove some LOCAL_INCLUDES now :)

Comment 4

Boris Zbarsky [:bz] (still a bit busy) 2012-05-18 06:32:54 PDT

Lovely!

Note You need to log in before you can comment on or make changes to this bug.