755045 - Fix build warnings under layout/

Status: RESOLVED FIXED

(Core :: Layout, defect)

Comment 1

[Josh Matthews [:jdm]]

Attachment: <required>

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 623819 [details] [diff] [review]
<required>

Review of attachment 623819 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/generic/nsHTMLCanvasFrame.cpp
@@ +85,3 @@
>    virtual nsRegion GetOpaqueRegion(nsDisplayListBuilder* aBuilder,
>                                     bool* aSnap,
>                                     bool* aForceTransparentSurface) {

Ah, this is actually a bug!!! The signature changed recently (bug 681192) and I forgot to fix this method! Can you remove the aForceTransparentSurface parameter please?

Comment 3

[Josh Matthews [:jdm]]

Attachment: Fix signed/unsigned warning and correct shadowed method that wasn't updated aong with with its parent class.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 623830 [details] [diff] [review]
Fix signed/unsigned warning and correct shadowed method that wasn't updated aong with with its parent class.

Review of attachment 623830 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/generic/nsHTMLCanvasFrame.cpp
@@ +85,1 @@
>      *aForceTransparentSurface = false;

Take this out or it won't build

Comment 5

[Jonathan Watt [:jwatt]]

Looks like the FrameLayerBuilder issue was fixed in bug 754488 and the nsHTMLCanvasFrame issue was fixed in bug 763451.