The default bug view has changed. See this FAQ.

Fix build warnings under layout/

RESOLVED FIXED

Status

()

Core
Layout
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jdm, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Reporter)

Comment 1

5 years ago
Created attachment 623819 [details] [diff] [review]
<required>
Attachment #623819 - Flags: review?(roc)
Comment on attachment 623819 [details] [diff] [review]
<required>

Review of attachment 623819 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/generic/nsHTMLCanvasFrame.cpp
@@ +85,3 @@
>    virtual nsRegion GetOpaqueRegion(nsDisplayListBuilder* aBuilder,
>                                     bool* aSnap,
>                                     bool* aForceTransparentSurface) {

Ah, this is actually a bug!!! The signature changed recently (bug 681192) and I forgot to fix this method! Can you remove the aForceTransparentSurface parameter please?
Blocks: 681192
(Reporter)

Comment 3

5 years ago
Created attachment 623830 [details] [diff] [review]
Fix signed/unsigned warning and correct shadowed method that wasn't updated aong with with its parent class.
Attachment #623830 - Flags: review?(roc)
(Reporter)

Updated

5 years ago
Attachment #623819 - Attachment is obsolete: true
Attachment #623819 - Flags: review?(roc)
Comment on attachment 623830 [details] [diff] [review]
Fix signed/unsigned warning and correct shadowed method that wasn't updated aong with with its parent class.

Review of attachment 623830 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/generic/nsHTMLCanvasFrame.cpp
@@ +85,1 @@
>      *aForceTransparentSurface = false;

Take this out or it won't build
Attachment #623830 - Flags: review?(roc) → review+
Looks like the FrameLayerBuilder issue was fixed in bug 754488 and the nsHTMLCanvasFrame issue was fixed in bug 763451.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.