755074 - [sumomo] fix groups so you don't get internal 500 error when accessing the profiles of people in groups

Status: RESOLVED FIXED

(support.mozillamessaging.com Graveyard :: General, defect)

Description

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

:gozer, :sancus has the details on how to fix this

steps to reproduce:

1. internal server error when you access somebody in groups e.g.
https://support.mozillamessaging.com/en-US/user/4

2. but internal server error when you access somebody who is NOT in groups
e.g.
https://support.mozillamessaging.com/en-US/user/8

here's what sancus wrote in IRC about this:
[15:15] <sancus> just need to query in the data for each group
[15:15] <sancus> mysql> describe groups_groupprofile;
[15:15] <sancus> +------------------+--------------+------+-----+---------+----------------+
[15:15] <sancus> | Field            | Type         | Null | Key | Default | Extra          |
[15:15] <sancus> +------------------+--------------+------+-----+---------+----------------+
[15:15] <sancus> | id               | int(11)      | NO   | PRI | NULL    | auto_increment | 
[15:15] <sancus> | slug             | varchar(80)  | NO   | UNI | NULL    |                | 
[15:15] <sancus> | group_id         | int(11)      | NO   | MUL | NULL    |                | 
[15:15] <sancus> | information      | longtext     | NO   |     | NULL    |                | 
[15:15] <sancus> | information_html | longtext     | NO   |     | NULL    |                | 
[15:15] <sancus> | avatar           | varchar(250) | YES  |     | NULL    |                | 
[15:15] <sancus> +------------------+--------------+------+-----+---------+----------------+
[15:15] <sancus> 6 rows in set (0.02 sec)
[15:15] <sancus> but I need gozer to do it anyway

Comment 1

[Philippe M. Chiasson (:gozer)]

mysql> describe groups_groupprofile;
+------------------+--------------+------+-----+---------+----------------+
| Field            | Type         | Null | Key | Default | Extra          |
+------------------+--------------+------+-----+---------+----------------+
| id               | int(11)      | NO   | PRI | NULL    | auto_increment |
| slug             | varchar(80)  | NO   | UNI | NULL    |                |
| group_id         | int(11)      | NO   | MUL | NULL    |                |
| information      | longtext     | NO   |     | NULL    |                |
| information_html | longtext     | NO   |     | NULL    |                |
| avatar           | varchar(250) | YES  |     | NULL    |                |
+------------------+--------------+------+-----+---------+----------------+

mysql> select * from groups_groupprofile;
Empty set (0.00 sec)

Comment 2

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

:sancus still getting this error, any update?
https://support.mozillamessaging.com/de/user/13630 (is another example user)

Comment 4

[Peter Pin-Guang Chen [:petercpg] (MozTW.org)]

Same problem for me, https://support.mozillamessaging.com/en-US/user/8210

Comment 5

[David Weir (satdav)]

same error for me 

https://support.mozillamessaging.com/en-US/user/4596

can you please fix this asap

Comment 6

[Andrei Hajdukewycz [:sancus]]

gozer: Can you do a "SELECT * from auth_groups;" and post the output? 

This should be fixable by inserting data into groups_groupprofile but I need the ids for the groups to make sure they match up.

Comment 7

[Andrei Hajdukewycz [:sancus]]

er, I meant auth_group not groups

Comment 8

[Philippe M. Chiasson (:gozer)]

mysql> select * from auth_group;
+----+----------------+
| id | name           |
+----+----------------+
|  8 | Contributors   |
|  2 | Locale leaders |
|  6 | Reviewers      |
+----+----------------+

Comment 9

[Andrei Hajdukewycz [:sancus]]

OK, now run:

INSERT INTO groups_groupprofile VALUES(1, 'Contributors', 8, 'Contributors', 'Contributors', '');
INSERT INTO groups_groupprofile VALUES(2, 'Locale Leaders', 2, 'Locale Leaders', 'Locale Leaders', '');
INSERT INTO groups_groupprofile VALUES(3, 'Reviewers', 6, 'Reviewers', 'Reviewers', '');

Comment 10

[Philippe M. Chiasson (:gozer)]

mysql> select * from groups_groupprofile;
+----+----------------+----------+----------------+------------------+--------+
| id | slug           | group_id | information    | information_html | avatar |
+----+----------------+----------+----------------+------------------+--------+
|  1 | Contributors   |        8 | Contributors   | Contributors     |        |
|  2 | Locale Leaders |        2 | Locale Leaders | Locale Leaders   |        |
|  3 | Reviewers      |        6 | Reviewers      | Reviewers        |        |
+----+----------------+----------+----------------+------------------+--------+
3 rows in set (0.00 sec)

Comment 11

[Philippe M. Chiasson (:gozer)]

Can this be resolved now ?

Comment 12

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

i still get internal server error 500 when i go here
https://support.mozillamessaging.com/en-US/user/4

so IMHO still not fixed

:sancus has this been rolled out to production?

Comment 13

[Andrei Hajdukewycz [:sancus]]

Yeah I don't think it fixed it all the way, even though it did stop the error spam I was getting from the server... I'll look into it. This is not fixed yet.