755158 - Update JSCompartment::debuggees for CPG

Status: RESOLVED WORKSFORME

(Core :: JavaScript Engine, defect)

Description

[Nicholas Nethercote [inactive]]

JSCompartments::debuggees has this declaration:

    /*
     * Weak reference to each global in this compartment that is a debuggee.
     * Each global has its own list of debuggers.
     */
    js::GlobalObjectSet              debuggees;

Sounds like that's a candidate for a post-CPG clean-up.  I can see two approaches:

1. Move it into the JSRuntime.

2. Change it to a single pointer (GlobalObject *) or even a single bit (which just indicates if the compartment's global is a debuggee).

Option 2 sounds like it might simplify the code more, but I'm not certain.

Comment 1

[Nicholas Nethercote [inactive]]

BTW, |debuggees| takes up 512 bytes per compartment, even though it's empty in the common case(?)  We now have ~100 compartments on start-up, so that's 50KB.

Comment 2

[Nicholas Nethercote [inactive]]

|debuggees| is now part of the Debugger class, so I don't think this is relevant any more.