spdysession::readsegments may not set reader without transaction

RESOLVED FIXED in mozilla15

Status

()

Core
Networking: HTTP
--
minor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mcmanus, Assigned: mcmanus)

Tracking

unspecified
mozilla15
x86_64
Windows 7
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [spdy])

Attachments

(1 attachment)

mSegmentReader is not set from the passed in argument in spdysession::readsegments if no corresponding stream is found. however it is still possible that data should go out to the network by flushing the output queue. a SETTINGS frame or a PING frame (as I discovered by reading logs) are examples of this. They will eventually go out when a transaction is placed on this session but particular in the case of a time sensitive item like PING should not wait.

(there might not be a transaction in the case of a nullhttptransaction, or a canceled transaction).

I can't think of anything this would actually harm. In the case of PING it might result in an unused connection being closed at a different time than expected but not in a (afaict) bad way.
Created attachment 623928 [details] [diff] [review]
patch 0
Assignee: nobody → mcmanus
Status: NEW → ASSIGNED
Attachment #623928 - Flags: review?(honzab.moz)
Comment on attachment 623928 [details] [diff] [review]
patch 0

Review of attachment 623928 [details] [diff] [review]:
-----------------------------------------------------------------

r=honzab
Attachment #623928 - Flags: review?(honzab.moz) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/47512e66a12e
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/47512e66a12e
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.