755181 - Show proper messaging if Sync fails due to multiple Fennec Native installs

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: Android Sync, defect, P2)

Description

[Tony Chung [:tchung]]

Attachment: desktop screenshot Sync connected message

This is probably a dupe of the work in bug 710407.   but i wanted to call out specifically in this bug the confusion that the UX is showing on both Android and Desktop when the expected Sync (with multiple Fennec install fails)

When sync setup expectantly fails because i have beta, nightly, and/or Aurora installed, the UI is presented with a hopeful screen to try again and reconnect.   On the desktop side, firefox pops up the dialog that the device has successfully connected.

We all know that the sync has and will continue to fail due to this log.  I propose we fix the messaging on Android to show the correct screen and UI because of this:

05-14 21:33:34.173: A/FxSync(29543): Unable to create account. If you have more than one version of Firefox/Beta/Aurora/Nightly/Fennec installed, that's why.
05-14 21:33:34.173: A/FxSync(29543): java.lang.SecurityException: caller uid 10072 is different than the authenticator's uid
05-14 21:33:34.173: A/FxSync(29543): 	at android.os.Parcel.readException(Parcel.java:1327)
05-14 21:33:34.173: A/FxSync(29543): 	at android.os.Parcel.readException(Parcel.java:1281)
05-14 21:33:34.173: A/FxSync(29543): 	at android.accounts.IAccountManager$Stub$Proxy.addAccount(IAccountManager.java:547)
05-14 21:33:34.173: A/FxSync(29543): 	at android.accounts.AccountManager.addAccountExplicitly(AccountManager.java:516)
05-14 21:33:34.173: A/FxSync(29543): 	at org.mozilla.gecko.sync.setup.SyncAccounts.createSyncAccount(SyncAccounts.java:189)
05-14 21:33:34.173: A/FxSync(29543): 	at org.mozilla.gecko.sync.setup.activities.SetupSyncActivity.onComplete(SetupSyncActivity.java:377)
05-14 21:33:34.173: A/FxSync(29543): 	at org.mozilla.gecko.sync.jpake.JPakeClient.complete(JPakeClient.java:350)
05-14 21:33:34.173: A/FxSync(29543): 	at org.mozilla.gecko.sync.jpake.stage.CompleteStage.execute(CompleteStage.java:12)
05-14 21:33:34.173: A/FxSync(29543): 	at org.mozilla.gecko.sync.jpake.JPakeClient.runNextStage(JPakeClient.java:226)
05-14 21:33:34.173: A/FxSync(29543): 	at org.mozilla.gecko.sync.jpake.stage.DecryptDataStage.execute(DecryptDataStage.java:79)
05-14 21:33:34.173: A/FxSync(29543): 	at org.mozilla.gecko.sync.jpake.JPakeClient.runNextStage(JPakeClient.java:226)
05-14 21:33:34.173: A/FxSync(29543): 	at org.mozilla.gecko.sync.jpake.stage.GetRequestStage$1.handleSuccess(GetRequestStage.java:71)
05-14 21:33:34.173: A/FxSync(29543): 	at org.mozilla.gecko.sync.jpake.stage.GetRequestStage$2.handleHttpResponse(GetRequestStage.java:120)
05-14 21:33:34.173: A/FxSync(29543): 	at org.mozilla.gecko.sync.net.BaseResource.execute(BaseResource.java:247)
05-14 21:33:34.173: A/FxSync(29543): 	at org.mozilla.gecko.sync.net.BaseResource.go(BaseResource.java:269)
05-14 21:33:34.173: A/FxSync(29543): 	at org.mozilla.gecko.sync.net.BaseResource.get(BaseResource.java:275)
05-14 21:33:34.173: A/FxSync(29543): 	at org.mozilla.gecko.sync.jpake.stage.GetRequestStage$GetStepTimerTask.run(GetRequestStage.java:194)
05-14 21:33:34.173: A/FxSync(29543): 	at java.util.Timer$TimerImpl.run(Timer.java:284)
05-14 21:33:34.173: E/SyncAccounts(29543): Failed to add account Account {name=[e-mail], type=org.mozilla.firefox_sync}!

Repro:
1) install firefox beta 1, Galaxy Nexus.  But also have another fennec native installed (aurora, nightly)
2) launch firefox > Sync, and pair to a desktop firefox
3) Desktop firefox will say Device Connected (see screenshot 1) 
4) Verify on Android, sync fails to sync, but the error shown gives the impression that there was a server error, and you can try again or use Classic setup.    The problem is, the user will try and try, and never intuitively understand they need to uninstall another fennec native version.  (see screenshot 2)

Expected:
- have a better android sync screen telling the user they need to uninstall other Fennec Native installations before proceeding   (requires string change)

Actual:
- desktop and android sync screens are contradictory and unclear

Comment 1

[Tony Chung [:tchung]]

Attachment: Android screenshot Sync Try Again Server error

Comment 2

[Richard Newman [:rnewman]]

Nothing had been done for this until now because it needs additional strings, if cementing this situation is even the best way forward. Still string frozen, so I don't know what we could do here for release.

Comment 3

[Tony Chung [:tchung]]

(In reply to Richard Newman [:rnewman] from comment #2)
> Nothing had been done for this until now because it needs additional
> strings, if cementing this situation is even the best way forward. Still
> string frozen, so I don't know what we could do here for release.

Understood, but i'd like to hear a discussion ongoing toward a solution, if not already.  We shouldn't ignore it because its very plausible for users to have beta and release installed eventually since Mozilla advertises both in Google Play.

Comment 4

[Richard Newman [:rnewman]]

(In reply to Tony Chung [:tchung] from comment #3)

> Understood, but i'd like to hear a discussion ongoing toward a solution, if
> not already.  We shouldn't ignore it because its very plausible for users to
> have beta and release installed eventually since Mozilla advertises both in
> Google Play.

Not ignoring it; it's just impossible to fix :)

Discussion is here:

https://wiki.mozilla.org/User:Anaaktgeboren/NativeSync#Developer_Overview

Comment 5

[Allison Naaktgeboren :ally]

sync triage: we'd like to improve this, but there isnt much we can do, and we cannot do anything for the beta/release 1.0

Comment 6

[Tony Chung [:tchung]]

(In reply to :Ally Naaktgeboren from comment #5)
> sync triage: we'd like to improve this, but there isnt much we can do, and
> we cannot do anything for the beta/release 1.0

Thanks, even if we have an action to relnote this or state ally's wiki notes on a more publicized blog, that would be good enough for me.

Comment 7

[Allison Naaktgeboren :ally]

we already rel noted this. it was a beta blocker. bug 710407

Comment 8

[Allison Naaktgeboren :ally]

mobile triage: would like to see this in 15, so the sync team should consider getting the required string in on nightly sooner rather than later.

Comment 9

[Nick Alexander :nalexander [he/him]]

How do we feel about FIXED WORKSFORME?  Work on Bug 761206 (specifically, Bug 772645) has essentially addressed this.  In fact, we could make this bug be: *remove* what messaging we do have in place, since it is no longer necessary (and should never be displayed).