Closed
Bug 755202
Opened 14 years ago
Closed 14 years ago
Simplify GetChildNodesForOperation
Categories
(Core :: DOM: Editor, defect)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: Ms2ger, Assigned: Ms2ger)
Details
Attachments
(1 file)
|
1.68 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #623962 -
Flags: review?(ehsan)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 623962 [details] [diff] [review]
Patch v1
Review of attachment 623962 [details] [diff] [review]:
-----------------------------------------------------------------
::: editor/libeditor/html/nsHTMLEditRules.cpp
@@ +5958,5 @@
> +
> + for (nsIContent* child = node->GetFirstChild();
> + child;
> + child = child->GetNextSibling()) {
> + nsIDOMNode* node = child->AsDOMNode();
Nit: rename this variable to something like childNode.
@@ +5964,1 @@
> return NS_ERROR_FAILURE;
Hmm, I'm pretty sure that nsCOMArray is infallible these days, so this shouldn't be necessary... But if you're not sure, let's leave it in.
Attachment #623962 -
Flags: review?(ehsan) → review+
|
Assignee | |
Comment 2•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in
before you can comment on or make changes to this bug.
Description
•