Last Comment Bug 755202 - Simplify GetChildNodesForOperation
: Simplify GetChildNodesForOperation
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Editor (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla15
Assigned To: :Ms2ger
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-15 00:38 PDT by :Ms2ger
Modified: 2012-05-18 02:52 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (1.68 KB, patch)
2012-05-15 00:38 PDT, :Ms2ger
ehsan: review+
Details | Diff | Review

Description :Ms2ger 2012-05-15 00:38:27 PDT
Created attachment 623962 [details] [diff] [review]
Patch v1
Comment 1 :Ehsan Akhgari (busy, don't ask for review please) 2012-05-16 06:49:13 PDT
Comment on attachment 623962 [details] [diff] [review]
Patch v1

Review of attachment 623962 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/libeditor/html/nsHTMLEditRules.cpp
@@ +5958,5 @@
> +
> +  for (nsIContent* child = node->GetFirstChild();
> +       child;
> +       child = child->GetNextSibling()) {  
> +    nsIDOMNode* node = child->AsDOMNode();

Nit: rename this variable to something like childNode.

@@ +5964,1 @@
>        return NS_ERROR_FAILURE;

Hmm, I'm pretty sure that nsCOMArray is infallible these days, so this shouldn't be necessary...  But if you're not sure, let's leave it in.

Note You need to log in before you can comment on or make changes to this bug.