Closed Bug 755202 Opened 11 years ago Closed 11 years ago

Simplify GetChildNodesForOperation

Categories

(Core :: DOM: Editor, defect)

Product:
Core
Component:
DOM: Editor
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla15

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Details

Attachments

(1 file)

Patch v1
1.68 KB, patch
ehsan.akhgari
: review+
Details | Diff | Splinter Review
Attached patch Patch v1 — — Splinter Review 
      No description provided.
Attachment #623962 - Flags: review?(ehsan)
Comment on attachment 623962 [details] [diff] [review]
Patch v1

Review of attachment 623962 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/libeditor/html/nsHTMLEditRules.cpp
@@ +5958,5 @@
> +
> +  for (nsIContent* child = node->GetFirstChild();
> +       child;
> +       child = child->GetNextSibling()) {  
> +    nsIDOMNode* node = child->AsDOMNode();

Nit: rename this variable to something like childNode.

@@ +5964,1 @@
>        return NS_ERROR_FAILURE;

Hmm, I'm pretty sure that nsCOMArray is infallible these days, so this shouldn't be necessary...  But if you're not sure, let's leave it in.
Attachment #623962 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/1dac5c37d560
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.