Closed Bug 755320 Opened 10 years ago Closed 10 years ago

having remote="true" in iframe breaks page loading

Categories

(Core :: DOM: Core & HTML, defect)

x86_64
Linux
defect
Not set
major

Tracking

()

RESOLVED FIXED
mozilla15

People

(Reporter: smaug, Assigned: justin.lebar+bug)

References

()

Details

Attachments

(1 file)

No description provided.
Summary: having remote="true" in iframe break page loading → having remote="true" in iframe breaks page loading
Indeed, there's no check in nsFrameLoader::ShouldUseRemoteProcess that the element is XUL...
I'm touching this code in bug 755001; I can fix it there.
Depends on: 755001
Attached patch Patch v1Splinter Review
Attachment #624069 - Flags: review?(bugs)
Attachment #624069 - Flags: review?(bugs) → review+
Sorry had to back the push out for failures in test_browserFrame7.html:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=f177646e2aa2

{
3390 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/browser-frame/test_browserFrame7.html | top [object Window] != [object Window]
3391 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/browser-frame/test_browserFrame7.html | parent [object Window] != [object Window]
3392 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/browser-frame/test_browserFrame7.html | frameElement [object HTMLIFrameElement] != null
3393 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/browser-frame/test_browserFrame7.html | inner top [object Window] != [object Window]
}

https://hg.mozilla.org/integration/mozilla-inbound/rev/d124a9678e93
Please follow the tree rules when landing on inbound (posting a changeset link, setting target milestone, etc.)

https://hg.mozilla.org/integration/mozilla-inbound/rev/503896a5e4e0
https://hg.mozilla.org/mozilla-central/rev/503896a5e4e0
Assignee: nobody → justin.lebar+bug
Flags: in-testsuite+
Target Milestone: --- → mozilla15
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.