having remote="true" in iframe breaks page loading

RESOLVED FIXED in mozilla15

Status

()

Core
DOM
--
major
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: smaug, Assigned: Justin Lebar (not reading bugmail))

Tracking

unspecified
mozilla15
x86_64
Linux
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

Comment hidden (empty)
(Reporter)

Updated

5 years ago
Summary: having remote="true" in iframe break page loading → having remote="true" in iframe breaks page loading
(Assignee)

Comment 1

5 years ago
Indeed, there's no check in nsFrameLoader::ShouldUseRemoteProcess that the element is XUL...
(Assignee)

Comment 2

5 years ago
I'm touching this code in bug 755001; I can fix it there.
(Assignee)

Updated

5 years ago
Depends on: 755001
(Assignee)

Comment 3

5 years ago
Created attachment 624069 [details] [diff] [review]
Patch v1
Attachment #624069 - Flags: review?(bugs)
(Reporter)

Updated

5 years ago
Attachment #624069 - Flags: review?(bugs) → review+
Sorry had to back the push out for failures in test_browserFrame7.html:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=f177646e2aa2

{
3390 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/browser-frame/test_browserFrame7.html | top [object Window] != [object Window]
3391 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/browser-frame/test_browserFrame7.html | parent [object Window] != [object Window]
3392 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/browser-frame/test_browserFrame7.html | frameElement [object HTMLIFrameElement] != null
3393 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/browser-frame/test_browserFrame7.html | inner top [object Window] != [object Window]
}

https://hg.mozilla.org/integration/mozilla-inbound/rev/d124a9678e93
(Assignee)

Comment 5

5 years ago
This is ready to go once the tree re-opens:

https://tbpl.mozilla.org/?tree=Try&rev=ce96987a69b9
https://tbpl.mozilla.org/?tree=Try&rev=44e6c42cfc09
Please follow the tree rules when landing on inbound (posting a changeset link, setting target milestone, etc.)

https://hg.mozilla.org/integration/mozilla-inbound/rev/503896a5e4e0
https://hg.mozilla.org/mozilla-central/rev/503896a5e4e0
Assignee: nobody → justin.lebar+bug
Flags: in-testsuite+
Target Milestone: --- → mozilla15
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.