Beginning on October 25th, 2016, Persona will no longer be an option for authentication on BMO. For more details see Persona Deprecated.
Last Comment Bug 755320 - having remote="true" in iframe breaks page loading
: having remote="true" in iframe breaks page loading
Product: Core
Classification: Components
Component: DOM (show other bugs)
: unspecified
: x86_64 Linux
: -- major (vote)
: mozilla15
Assigned To: Justin Lebar (not reading bugmail)
: Andrew Overholt [:overholt]
data:text/html,<iframe remote="true" ...
Depends on: 755001
  Show dependency treegraph
Reported: 2012-05-15 08:38 PDT by Olli Pettay [:smaug]
Modified: 2012-05-16 19:22 PDT (History)
3 users (show)
ryanvm: in‑testsuite+
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch v1 (2.85 KB, patch)
2012-05-15 09:16 PDT, Justin Lebar (not reading bugmail)
bugs: review+
Details | Diff | Splinter Review

Description Olli Pettay [:smaug] 2012-05-15 08:38:16 PDT

Comment 1 Justin Lebar (not reading bugmail) 2012-05-15 08:44:22 PDT
Indeed, there's no check in nsFrameLoader::ShouldUseRemoteProcess that the element is XUL...
Comment 2 Justin Lebar (not reading bugmail) 2012-05-15 08:47:27 PDT
I'm touching this code in bug 755001; I can fix it there.
Comment 3 Justin Lebar (not reading bugmail) 2012-05-15 09:16:40 PDT
Created attachment 624069 [details] [diff] [review]
Patch v1
Comment 4 Ed Morley [:emorley] 2012-05-15 10:40:21 PDT
Sorry had to back the push out for failures in test_browserFrame7.html:

3390 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/browser-frame/test_browserFrame7.html | top [object Window] != [object Window]
3391 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/browser-frame/test_browserFrame7.html | parent [object Window] != [object Window]
3392 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/browser-frame/test_browserFrame7.html | frameElement [object HTMLIFrameElement] != null
3393 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/browser-frame/test_browserFrame7.html | inner top [object Window] != [object Window]
Comment 5 Justin Lebar (not reading bugmail) 2012-05-15 20:25:21 PDT
This is ready to go once the tree re-opens:
Comment 6 Ryan VanderMeulen [:RyanVM] 2012-05-16 19:21:41 PDT
Please follow the tree rules when landing on inbound (posting a changeset link, setting target milestone, etc.)

Note You need to log in before you can comment on or make changes to this bug.