755320 - having remote="true" in iframe breaks page loading

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Justin Lebar (not reading bugmail)]

Indeed, there's no check in nsFrameLoader::ShouldUseRemoteProcess that the element is XUL...

Comment 2

[Justin Lebar (not reading bugmail)]

I'm touching this code in bug 755001; I can fix it there.

Comment 3

[Justin Lebar (not reading bugmail)]

Attachment: Patch v1

Comment 4

[Ed Morley [:emorley]]

Sorry had to back the push out for failures in test_browserFrame7.html:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=f177646e2aa2

{
3390 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/browser-frame/test_browserFrame7.html | top [object Window] != [object Window]
3391 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/browser-frame/test_browserFrame7.html | parent [object Window] != [object Window]
3392 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/browser-frame/test_browserFrame7.html | frameElement [object HTMLIFrameElement] != null
3393 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/browser-frame/test_browserFrame7.html | inner top [object Window] != [object Window]
}

https://hg.mozilla.org/integration/mozilla-inbound/rev/d124a9678e93

Comment 5

[Justin Lebar (not reading bugmail)]

This is ready to go once the tree re-opens:

https://tbpl.mozilla.org/?tree=Try&rev=ce96987a69b9
https://tbpl.mozilla.org/?tree=Try&rev=44e6c42cfc09

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Please follow the tree rules when landing on inbound (posting a changeset link, setting target milestone, etc.)

https://hg.mozilla.org/integration/mozilla-inbound/rev/503896a5e4e0
https://hg.mozilla.org/mozilla-central/rev/503896a5e4e0