Closed
Bug 755350
Opened 14 years ago
Closed 14 years ago
Add back-end features to set featured versions
Categories
(Socorro :: Webapp, task)
Socorro
Webapp
Tracking
(Not tracked)
RESOLVED
FIXED
16
People
(Reporter: adrian, Assigned: adrian)
References
Details
(Whiteboard: [qa-])
The way we set featured versions needs to change, as it changed in the back-end. What we intend to do is described in bug 755231. To do that, we first need a function in the branch model that takes new lists of featured versions and send them to a middleware service.
The SQL function has the following spec:
> change_featured_versions (
> product_name
> featured_versions ARRAY-OF-VERSION-STRINGS
> )
The middleware service will accept a PUT method containing data like so:
> 'product' = ['version1', 'version2'],
> ...
For example:
> 'Firefox' = ['14.0a1', '15.0a1', '13.0b2', '12'],
> 'FennecAndroid' = ['15.0a1', '14.0a2']
The branch will then have a method that follows the same spec:
> function update_featured_versions(array $featured)
> $featured = array(
> 'Firefox' => array('14.0a1', '15.0a1', '13.0b2', '12'),
> 'FennecAndroid' => array('15.0a1', '14.0a2')
> );
@Schalk: does that work for you? Do you see any flaws in this spec? Will it be simple to use from the admin controller?
@Josh: this spec implies that every time someone changes one featured versions list for any product, all products will get updated (basically, one call to change_featured_versions per product). Is that valid, or ugly in terms of performances? As it is a purely admin function, it is really not critical, but I'm curious.
| Assignee | ||
Updated•14 years ago
|
Whiteboard: [qa-]
Target Milestone: 10 → 11
| Assignee | ||
Updated•14 years ago
|
Target Milestone: 11 → 12
| Assignee | ||
Updated•14 years ago
|
Target Milestone: 12 → 13
| Assignee | ||
Comment 1•14 years ago
|
||
Comment 2•14 years ago
|
||
Commits pushed to admin-refactor at https://github.com/mozilla/socorro
https://github.com/mozilla/socorro/commit/21b6dc38f4e9271c05ccdafb8040e690cd2b0789
Fixes bug 755350 - Added back-end features for updating featured versions.
https://github.com/mozilla/socorro/commit/37ea2a58ee92076b74771922762da422a43cb1bf
Merge pull request #630 from AdrianGaudebert/755350-update-featured-versions-service
Fixes bug 755350 - Added back-end features for updating featured versions.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment 3•14 years ago
|
||
Commit pushed to admin-refactor at https://github.com/mozilla/socorro
https://github.com/mozilla/socorro/commit/927b2e8eb5e0e15549f90ec00aa00fe99abab1d0
Fixes bug 755350 - Added back-end features for updating featured versions.
| Assignee | ||
Updated•14 years ago
|
Target Milestone: 13 → 14
Comment 4•14 years ago
|
||
Commit pushed to admin-refactor at https://github.com/mozilla/socorro
https://github.com/mozilla/socorro/commit/8232c17040062fe8bc2a05512bab8d47cb767cb0
Fixes bug 755350 - Added back-end features for updating featured versions.
Comment 5•14 years ago
|
||
Commit pushed to admin-refactor at https://github.com/mozilla/socorro
https://github.com/mozilla/socorro/commit/927b2e8eb5e0e15549f90ec00aa00fe99abab1d0
Fixes bug 755350 - Added back-end features for updating featured versions.
Comment 6•14 years ago
|
||
Commit pushed to admin-refactor at https://github.com/mozilla/socorro
https://github.com/mozilla/socorro/commit/e43bee4e51c9fb918bc26161ec71731e7cbd50bd
Fixes bug 755350 - Added back-end features for updating featured versions.
| Assignee | ||
Updated•14 years ago
|
Target Milestone: 14 → 16
Comment 7•14 years ago
|
||
Commit pushed to master at https://github.com/mozilla/socorro
https://github.com/mozilla/socorro/commit/e43bee4e51c9fb918bc26161ec71731e7cbd50bd
Fixes bug 755350 - Added back-end features for updating featured versions.
You need to log in
before you can comment on or make changes to this bug.
Description
•