Closed Bug 755458 Opened 12 years ago Closed 12 years ago

Fix SeaMonkey download manager tests after removal of mozIStorageStatementWrapper

Categories

(SeaMonkey :: Download & File Handling, defect)

Product:
SeaMonkey
Component:
Download & File Handling
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.12 fixed)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.12
Tracking Flags:
Tracking Status
seamonkey2.12 --- fixed

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

(
URL
)

Details

Attachments

(1 file)

Unwrap the statements [Checked in: Comment 2]
9.32 KB, patch
sgautherie
: review+
Details | Diff | Splinter Review 
Bug 589032 removed mozIStorageStatementWrapper and the tests for download manager are currently broken on trunk.

Followed blog note as mentioned in bug 589032 comment 27

Fairly simple process, only gotcha was keeping with execute() rather than moving to executeStep()
Attachment #624150 - Flags: review?(sgautherie.bz)
Attachment #624150 - Flags: review?(kairo)
Attachment #624150 - Attachment description: Unwrap the statments → Unwrap the statements
Comment on attachment 624150 [details] [diff] [review]
Unwrap the statements [Checked in: Comment 2]

(In reply to Ian Neal from comment #0)
> Followed blog note as mentioned in bug 589032 comment 27
> 
> Fairly simple process, only gotcha was keeping with execute() rather than
> moving to executeStep()

Indeed, I added a comment to that blog...
Attachment #624150 - Flags: review?(sgautherie.bz) → review+
Summary: Fix download manager tests after removal of mozIStorageStatementWrapper → Fix SeaMonkey download manager tests after removal of mozIStorageStatementWrapper
Target Milestone: --- → seamonkey2.12
Comment on attachment 624150 [details] [diff] [review]
Unwrap the statements [Checked in: Comment 2]

http://hg.mozilla.org/comm-central/rev/d87e0df241fc
Attachment #624150 - Attachment description: Unwrap the statements → Unwrap the statements [Checked in: Comment 2]
Attachment #624150 - Flags: review?(kairo)
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
status-seamonkey2.12: --- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: