755475 - Add support for setting the position of a window

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[David Burns :automatedtester]

We can't currently set the position of a window. Selenium Proxy and Marionette currently dont have support for this. 

 199 2012-05-11 13:36:51,794 - Selenium-Proxy - DEBUG - /position - None - 13 - current
 200 2012-05-11 13:36:51,794 - Selenium-Proxy - ERROR - Unknown path - 13 

This is documented in http://code.google.com/p/selenium/wiki/JsonWireProtocol#/session/:sessionId/window/:windowHandle/position

Comment 1

[David Burns :automatedtester]

https://tbpl.mozilla.org/?tree=Try&rev=d59845ebcf4e

Comment 2

[David Burns :automatedtester]

https://tbpl.mozilla.org/?tree=Try&rev=71e427821cd7

Comment 3

[David Burns :automatedtester]

https://tbpl.mozilla.org/?tree=Try&rev=7fc1bad2dc7d

Comment 4

[David Burns :automatedtester]

https://tbpl.mozilla.org/?tree=Try&rev=cd383d17016e

Comment 5

[David Burns :automatedtester]

Attachment: Allow the getting and setting of the currently browser window position from Marionette

Comment 6

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8487600 [details] [diff] [review]
Allow the getting and setting of the currently browser window position from Marionette

Review of attachment 8487600 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/marionette/client/marionette/tests/unit/test_window_position.py
@@ +9,5 @@
> +#Unless required by applicable law or agreed to in writing, software
> +#distributed under the License is distributed on an "AS IS" BASIS,
> +#WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> +#See the License for the specific language governing permissions and
> +#limitations under the License.

Why this license, are we using a WebDriver test?

@@ +19,5 @@
> +
> +    def test_that_we_return_the_window_position(self):
> +        position = self.marionette.get_window_position()
> +        self.assertGreater(position['x'], 0)
> +        self.assertGreater(position['y'], 0)

We can actually have negative positions, it's probably safer just to verify we get an int.

::: testing/marionette/marionette-server.js
@@ +1257,5 @@
>    },
>  
>    /**
> +   * Get the current window position. If called from a mobile context (b2g or fennec)
> +   * an unsupported operation error is returned to the client

This comment about this being unsupported on mobile is inaccurate for getWindowPosition, it applies to setWindowPosition below instead.

Comment 7

[David Burns :automatedtester]

(In reply to Jonathan Griffin (:jgriffin) from comment #6)
> Comment on attachment 8487600 [details] [diff] [review]
> Allow the getting and setting of the currently browser window position from
> Marionette
> 
> Review of attachment 8487600 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: testing/marionette/client/marionette/tests/unit/test_window_position.py
> @@ +9,5 @@
> > +#Unless required by applicable law or agreed to in writing, software
> > +#distributed under the License is distributed on an "AS IS" BASIS,
> > +#WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> > +#See the License for the specific language governing permissions and
> > +#limitations under the License.
> 
> Why this license, are we using a WebDriver test?
> 

Yes we are. This is the test verbatim except for the marionette variable 

> @@ +19,5 @@
> > +
> > +    def test_that_we_return_the_window_position(self):
> > +        position = self.marionette.get_window_position()
> > +        self.assertGreater(position['x'], 0)
> > +        self.assertGreater(position['y'], 0)
> 
> We can actually have negative positions, it's probably safer just to verify
> we get an int.
> 

Updated

> ::: testing/marionette/marionette-server.js
> @@ +1257,5 @@
> >    },
> >  
> >    /**
> > +   * Get the current window position. If called from a mobile context (b2g or fennec)
> > +   * an unsupported operation error is returned to the client
> 
> This comment about this being unsupported on mobile is inaccurate for
> getWindowPosition, it applies to setWindowPosition below instead.

Updated

Comment 8

[David Burns :automatedtester]

https://hg.mozilla.org/integration/mozilla-inbound/rev/38fe938f82c4

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/38fe938f82c4