755495 - make DEFAULT_WEBAPP_AMO_URL a list

Status: RESOLVED FIXED

(Marketplace Graveyard :: Validation, defect, P4)

Description

[Wil Clouser [:clouserw]]

From bug 747252 people are having trouble installing apps off marketplace-dev because the installs_allowed_from is marketplace.m.o.  The DEFAULT_WEBAPP_AMO_URL constant would let us adjust that, but it would override marketplace.m.o.  The goal of this bug is to allow installs on marketplace.m.o from '*' and 'marketplace.mozilla.org' and on marketplace-dev.a.o from '*', 'marketplace-dev.a.o', and 'marketplace.mozilla.org'

Effectively the whitelist should be a list instead of a string.  I see the validator tries to load from a constants_local file - what is the best way to get this list from the marketplace config into the amo-validator on the servers?

Comment 1

[Matt Basta [:basta]]

I can make a parameter in the validate.validate() function, if it would work best that way. That's probably most in line with what we've done for other settings constants (like the path to Spidermonkey).

I'll get started on converting that constant to a list, though.

Comment 2

[Matt Basta [:basta]]

Updated to a list here:

https://github.com/mattbasta/amo-validator/commit/144e3ac878be3df86428ae42a67f6463db55a691

Comment 3

[Wil Clouser [:clouserw]]

Still in progress or are you blocked?

Comment 4

[Matt Basta [:basta]]

Just added the new parameter this morning:

https://github.com/mattbasta/amo-validator/commit/6e45e922912099aea56f735d1109c9743447362b

Comment 5

[Matt Basta [:basta]]

Fixed:

https://github.com/mozilla/amo-validator/commit/99891a8d77ccd83d20372e62a52a938f7300803d