Update mozconfigs on sea-win32-02 to build with MSVC2010

RESOLVED FIXED in seamonkey2.13

Status

RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: ewong, Assigned: ewong)

Tracking

(Blocks: 1 bug)

Trunk
seamonkey2.13
x86
Windows Server 2003
Bug Flags:
in-testsuite -

SeaMonkey Tracking Flags

(seamonkey2.12 fixed)

Details

Attachments

(3 attachments, 6 obsolete attachments)

(Assignee)

Description

7 years ago
This is to slowly migrate our machines to using MSVC2010.  Since 
sea-win32-02 has MSVC2010 installed,  this bug is to have the
buildslave build using MSVC2010.
(Assignee)

Comment 1

7 years ago
Quote Callek from IRC:

 "we want trunk to build *only* on sea-win32-02, and have trunk also build only on MSVC2010"
(Assignee)

Updated

7 years ago
Version: SeaMonkey 2.10 Branch → Trunk
(Assignee)

Comment 2

7 years ago
Created attachment 624741 [details] [diff] [review]
Use MSVC2010 for win32 builds.

in-tree mozconfig changes.
Attachment #624741 - Flags: review?(bugspam.Callek)
(Assignee)

Comment 3

7 years ago
Created attachment 625005 [details] [diff] [review]
Use sea-win32-02 only for trunk builds. (v1)
Attachment #625005 - Flags: review?(bugspam.Callek)
Comment on attachment 625005 [details] [diff] [review]
Use sea-win32-02 only for trunk builds. (v1)

I *think* this is correct. Will verify in about 20 hours with a real review THANKS!!
Attachment #625005 - Flags: feedback+
(Assignee)

Comment 5

7 years ago
Created attachment 625552 [details] [diff] [review]
Use sea-win32-02 only for trunk builds. (v2)
Assignee: nobody → ewong
Attachment #625005 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #625005 - Flags: review?(bugspam.Callek)
Attachment #625552 - Flags: review?(bugspam.Callek)
Attachment #625552 - Flags: feedback?(bugspam.Callek)
Comment on attachment 625552 [details] [diff] [review]
Use sea-win32-02 only for trunk builds. (v2)

the BUILDS_BEFORE_REBOOT can land, but the slaves change can't (the slaves change eliminates the rest of our windows slaves from being able to test on trunk, thus bringing our trunk load WAAAAY bad)

I will get a patch up for you to review for that change, later. But in the meantime we *can* land the builds-before-reboot here. That does end up rebooting on builders as well, but thats no worry in the end, just means a *slightly* longer turnaround for some of these builds, but for a good clean slate I'm happy with that.
Attachment #625552 - Flags: review?(bugspam.Callek)
Attachment #625552 - Flags: review-
Attachment #625552 - Flags: feedback?(bugspam.Callek)
Attachment #625552 - Flags: feedback+
(Assignee)

Comment 7

7 years ago
Created attachment 626342 [details] [diff] [review]
Reboot builders before every build. (v3)
[Checked in: Comment 9]
Attachment #625552 - Attachment is obsolete: true
Attachment #626342 - Flags: review?(bugspam.Callek)

Updated

7 years ago
Attachment #626342 - Flags: review?(bugspam.Callek) → review+
Comment on attachment 624741 [details] [diff] [review]
Use MSVC2010 for win32 builds.

Review of attachment 624741 [details] [diff] [review]:
-----------------------------------------------------------------

::: suite/config/mozconfigs/win32/debug
@@ +6,4 @@
>  # For NSS symbols
>  export MOZ_DEBUG_SYMBOLS=1
>  
> +. $topsrcdir/config/mozconfigs/win32/mozconfig.vs2010

As is, this would seem to miss "/suite".

::: suite/config/mozconfigs/win32/mozconfigs.msvc2010
@@ +3,5 @@
> +export LIB=/d/msvs10/vc/lib:/d/msvs10/vc/atlmfc/lib:/d/sdks/v7.0/lib:/d/msvs8/VC/PlatformSDK/lib:/d/msvs8/SDK/v2.0/lib:/d/mozilla-build/atlthunk_compat:/d/sdks/dx10/lib/x86
> +export PATH="/d/msvs10/VSTSDB/Deploy:/d/msvs10/Common7/IDE/:/d/msvs10/VC/BIN:/d/msvs10/Common7/Tools:/d/msvs10/VC/VCPackages:${PATH}"
> +export WIN32_REDIST_DIR=/d/msvs10/VC/redist/x86/Microsoft.VC100.CRT
> +
> +

This seems right, but can't we just reuse what bug 748744 did?

::: suite/config/mozconfigs/win32/nightly
@@ +10,4 @@
>  # Needed to enable breakpad in application.ini
>  export MOZILLA_OFFICIAL=1
>  
> +. $topsrcdir/config/mozconfigs/win32/mozconfig.vs2010

As is, this would seem to miss "/suite".
(Assignee)

Comment 9

6 years ago
Pushed first patch (Reboot builders before every build.) to build/buildbot-configs:
http://hg.mozilla.org/build/buildbot-configs/rev/a3bb108c6746
(Assignee)

Comment 10

6 years ago
Created attachment 632097 [details] [diff] [review]
Use MSVC2010 for win32 builds. (v2)
Attachment #624741 - Attachment is obsolete: true
Attachment #624741 - Flags: review?(bugspam.Callek)
Attachment #632097 - Flags: review?(bugspam.Callek)
Comment on attachment 632097 [details] [diff] [review]
Use MSVC2010 for win32 builds. (v2)

Review of attachment 632097 [details] [diff] [review]:
-----------------------------------------------------------------

Not a formal review, but I *think* we *need* it like TB does:

http://mxr.mozilla.org/comm-central/source/mail/config/mozconfigs/win32/nightly

(ignoring -64 stuff)

because this file is included from m-c configure as well, iirc
Attachment #632097 - Flags: feedback-
(Assignee)

Comment 12

6 years ago
Created attachment 632167 [details] [diff] [review]
Use MSVC2010 for win32 builds. (v3)
[Checked in: Comment 19 & 18]
Attachment #632097 - Attachment is obsolete: true
Attachment #632097 - Flags: review?(bugspam.Callek)
Attachment #632167 - Flags: review?(bugspam.Callek)
Attachment #632167 - Flags: feedback?(sgautherie.bz)
(Assignee)

Comment 13

6 years ago
Created attachment 636040 [details] [diff] [review]
Use sea-vm-win32-* and sea-win32-02 to use MSVC2010 to build trunk.
Attachment #636040 - Flags: review?(bugspam.Callek)
(Assignee)

Comment 14

6 years ago
Created attachment 636042 [details] [diff] [review]
Use sea-vm-win32-* and sea-win32-02 to use MSVC2010 to build trunk. (v2)

Also removed cb-sea-win32-tbox.
Attachment #636040 - Attachment is obsolete: true
Attachment #636040 - Flags: review?(bugspam.Callek)
Attachment #636042 - Flags: review?(bugspam.Callek)
Comment on attachment 636042 [details] [diff] [review]
Use sea-vm-win32-* and sea-win32-02 to use MSVC2010 to build trunk. (v2)


>@@ -5,9 +5,8 @@ SLAVES = {
>              ['cn-sea-qm-centos5-%02i' % x for x in [1]] +
>              ['cb-sea-linux-tbox'],
>     'linux64': ['cb-seamonkey-linux64-%02i' % x for x in [1]],
>-    'win32': ['cb-seamonkey-win32-%02i' % x for x in [1,2,3]] +
>-             ['cn-sea-qm-win2k3-%02i' % x for x in [1]] +
>-             ['cb-sea-win32-tbox'] +
>+    'win32': ['cn-sea-qm-win2k3-%02i' % x for x in [1]] +
>+             ['sea-vm-win32-%02i' % x for x in [1,2,3,4]] +
>              ['sea-win32-%02i' % x for x in [2,3,4]], #iX machines

Please add sea-win32-01 to this last set (no need for extra review for that)

>     'macosx': ['cb-sea-miniosx%02i' % x for x in [1,2]],
>     'macosx64': ['cb-sea-miniosx64-%02i' % x for x in [1,2,3]],
>@@ -487,6 +486,11 @@ BRANCHES['comm-central-trunk']['aus2_bas
> # staging/production-dependent settings - all is production for us
> BRANCHES['comm-central-trunk']['tinderbox_tree'] = 'SeaMonkey'
> BRANCHES['comm-central-trunk']['packaged_unittest_tinderbox_tree'] = 'SeaMonkey'
>+BRANCHES['comm-central-trunk']['platforms']['win32']['slaves'] = ['sea-vm-win32-01',
>+                                                                  'sea-vm-win32-02',
>+                                                                  'sea-vm-win32-03',
>+                                                                  'sea-vm-win32-04',
>+                                                                  'sea-win32-02']

Nit: ['sea-vm-win32-%02i' % x for x in [1,2,3,4]] +
>              ['sea-win32-%02i' % x for x in [1,2,3,4]]

like above ;-) But if its easier for readability I'm ok with just adding the explicit sea-win32-01/03/04 entries as well.

Please land this and double-reconfig when you are free.
Attachment #636042 - Flags: review?(bugspam.Callek) → review+
(Assignee)

Comment 16

6 years ago
Created attachment 636047 [details] [diff] [review]
Use sea-vm-win32-* and sea-win32-02 to use MSVC2010 to build trunk. (v3)
[Checked in: Comment 20]

For some reasons my previous patch was against an old config.py.  The new config.py already has the sea-vm-win32-%i set.  So this patch just removes
cb-sea-win32-tbox and the old cb-seamonkey-win32-%02i.
Attachment #636042 - Attachment is obsolete: true
Attachment #636047 - Flags: review+
Comment on attachment 632167 [details] [diff] [review]
Use MSVC2010 for win32 builds. (v3)
[Checked in: Comment 19 & 18]

Review of attachment 632167 [details] [diff] [review]:
-----------------------------------------------------------------

This is working on trunk now. I'm pre-approving for aurora, but I'd like to land there after we get the other iX machines up (sea-win32-0X)
Attachment #632167 - Flags: review?(bugspam.Callek)
Attachment #632167 - Flags: review+
Attachment #632167 - Flags: feedback?(sgautherie.bz)

Updated

6 years ago
Attachment #632167 - Flags: approval-comm-aurora+
(Assignee)

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

6 years ago
status-seamonkey2.12: --- → fixed
Flags: in-testsuite-
Target Milestone: --- → seamonkey2.13
Attachment #626342 - Attachment description: Reboot builders before every build. (v3) → Reboot builders before every build. (v3) [Checked in: Comment 9]
Attachment #632167 - Attachment description: Use MSVC2010 for win32 builds. (v3) → Use MSVC2010 for win32 builds. (v3) [Checked in: Comment 18]
Comment on attachment 632167 [details] [diff] [review]
Use MSVC2010 for win32 builds. (v3)
[Checked in: Comment 19 & 18]

http://hg.mozilla.org/comm-central/rev/28be9af20eda
Attachment #632167 - Attachment description: Use MSVC2010 for win32 builds. (v3) [Checked in: Comment 18] → Use MSVC2010 for win32 builds. (v3) [Checked in: Comment 19 & 18]
Comment on attachment 636047 [details] [diff] [review]
Use sea-vm-win32-* and sea-win32-02 to use MSVC2010 to build trunk. (v3)
[Checked in: Comment 20]

http://hg.mozilla.org/build/buildbot-configs/rev/db0b3553f1e6
(empty)
+
http://hg.mozilla.org/build/buildbot-configs/rev/833dcd10f361
Attachment #636047 - Attachment description: Use sea-vm-win32-* and sea-win32-02 to use MSVC2010 to build trunk. (v3) → Use sea-vm-win32-* and sea-win32-02 to use MSVC2010 to build trunk. (v3) [Checked in: Comment 20]
You need to log in before you can comment on or make changes to this bug.